-
Notifications
You must be signed in to change notification settings - Fork 106
feat: support multimodal embeddings #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: support multimodal embeddings #237
Conversation
Summary of ChangesHello @Yeuoly, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the handling of multimodal data by integrating its core components directly into the existing text embedding and rerank functionalities. This change eliminates a separate multimodal module, streamlining the codebase and extending the capabilities of current models to process diverse input types like text and images for both embedding generation and document reranking. The update also includes the necessary plumbing for these new multimodal invocation paths and introduces dedicated unit tests to ensure proper functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively refactors the multimodal functionality by inlining it into the existing text embedding and rerank models. This simplifies the codebase by removing the standalone multimodal module. The changes are well-structured, with corresponding updates to request entities, executor logic, and model interfaces. The addition of a new test file with unit tests for the multimodal request path is a great inclusion that improves test coverage for the new functionality. My review includes a couple of suggestions to simplify the code by removing redundant type checks, which will improve readability and maintainability. Overall, this is a solid contribution.
| "query": query.model_dump() if isinstance(query, MultiModalContent) else query, | ||
| "docs": [doc.model_dump() if isinstance(doc, MultiModalContent) else doc for doc in docs], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type hints for query and docs are MultiModalContent and list[MultiModalContent] respectively. Pydantic ensures that these will be instances of MultiModalContent. Therefore, the isinstance checks are redundant and can be removed to simplify the code.
| "query": query.model_dump() if isinstance(query, MultiModalContent) else query, | |
| "docs": [doc.model_dump() if isinstance(doc, MultiModalContent) else doc for doc in docs], | |
| "query": query.model_dump(), | |
| "docs": [doc.model_dump() for doc in docs], |
| "documents": [ | ||
| document.model_dump() if isinstance(document, MultiModalContent) else document | ||
| for document in documents | ||
| ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
Testing
pytest python/tests/test_multimodal_requests.pyCodex Task