Skip to content

suggestions felix#2747

Open
felixkrrr wants to merge 2 commits intomainfrom
shorten-ai-get-started-suggestions-felix
Open

suggestions felix#2747
felixkrrr wants to merge 2 commits intomainfrom
shorten-ai-get-started-suggestions-felix

Conversation

@felixkrrr
Copy link
Copy Markdown
Contributor

@felixkrrr felixkrrr commented Mar 30, 2026

Merge everything into 1 Prompt
CleanShot 2026-03-30 at 14 15 52@2x

Installation Experience
CleanShot 2026-03-30 at 13 58 52@2x

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
langfuse-docs Ready Ready Preview, Comment Mar 30, 2026 0:16am

Request Review

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 30, 2026
@github-actions
Copy link
Copy Markdown

@claude review

@dosubot dosubot bot added the documentation Improvements or additions to documentation label Mar 30, 2026
Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward docs enhancement. One nit noted inline (missing CopyAgentPromptButton in the Cursor tab), and copyable-agent-prompt.tsx appears to be unused in this PR.

Extended reasoning...

Overview

This PR refactors the agentic installation section of the get-started docs. It introduces topic-specific agent prompts (observability vs. prompt-management), a reusable CopyAgentPromptButton component, and wires the auto-install MDX component to receive a topic prop. Eight files are touched: six new component files and two existing docs pages.

Security Risks

None. All changes are UI/docs — MDX content, React components with clipboard API usage, and static text. No auth, data handling, or external requests introduced.

Level of Scrutiny

Low. This is a documentation site with no production-critical logic. The components follow established patterns in the codebase, and the conditional rendering logic is simple and readable.

Other Factors

One nit flagged by the bug hunter (missing CopyAgentPromptButton in the Cursor plugin tab — already noted as an inline comment). Additionally, copyable-agent-prompt.tsx is added but not imported or used anywhere in this PR; it may be intended for future use or is leftover, but it does not cause any functional issues. Neither issue warrants blocking the PR.

Comment on lines +42 to 46
{props.topic === "observability" && <AgentPromptObservability />}
{props.topic === "prompt-management" && <AgentPromptPromptManagement />}
</Tab>

<Tab>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 The 'Cursor plugin' tab shows the agent prompt but is missing the that appears in the 'Ask your coding agent' tab. Adding after the prompt MDX components in the Cursor tab (around line 46 of auto-install.mdx) would restore consistency.

Extended reasoning...

Both tabs in auto-install.mdx display the same agent prompt via the conditional AgentPromptObservability / AgentPromptPromptManagement MDX components, and both were clearly intended to give users a prominent, labeled way to copy that prompt text. The PR introduced CopyAgentPromptButton and wired it up correctly in Tab 1 ('Ask your coding agent'), but the same button was not added to Tab 2 ('Cursor plugin').

The specific code path: in auto-install.mdx, Tab 1 ends with <CopyAgentPromptButton topic={props.topic} /> (line 20), while Tab 2 ends after the prompt MDX block with no corresponding button (lines 42–46). The import for CopyAgentPromptButton is already present at the top of the file, so the fix is simply a one-line addition.

Existing code does not compensate for this omission in a fully equivalent way. Fumadocs code blocks do render a small native copy icon, so the prompt text is not uncopyable — but that icon is small, unlabeled, and part of the code block UI rather than a standalone, discoverable action. The CopyAgentPromptButton is a larger, labeled button ('Copy Agent Prompt') that makes the action explicit, especially for users who may not notice the code-block icon.

The practical impact is a UX inconsistency: users who land on the Cursor plugin tab see a less polished experience than those on the first tab. The button's absence may also be mildly confusing if users notice it exists on Tab 1 but not Tab 2. There is no functional breakage, which is why this is nit-level.

The fix is minimal: add <CopyAgentPromptButton topic={props.topic} /> directly after the prompt MDX components in Tab 2, mirroring exactly what Tab 1 does. No new imports are needed since CopyAgentPromptButton is already imported.

Step-by-step proof: (1) A user visits the Cursor plugin tab. (2) They see the agent prompt rendered via AgentPromptObservability or AgentPromptPromptManagement. (3) They look for a 'Copy Agent Prompt' button like the one visible on the first tab — it is absent. (4) They must rely on the smaller native code-block copy icon or manually select the text. Meanwhile, a user on Tab 1 gets the large labeled button immediately below the prompt.

Base automatically changed from shorten-ai-get-started to main April 2, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants