Added vibration option in App Overrides #32
Open
ahmed-shehata wants to merge 12 commits intolangerhans:mainfrom
Open
Added vibration option in App Overrides #32ahmed-shehata wants to merge 12 commits intolangerhans:mainfrom
ahmed-shehata wants to merge 12 commits intolangerhans:mainfrom
Conversation
Collaborator
miguelguzmanr
left a comment
There was a problem hiding this comment.
I have added a review.
| } | ||
|
|
||
| companion object { | ||
| private const val KEY_VIBRATION_STRENGTH = "vibration_strength" |
Collaborator
There was a problem hiding this comment.
Property "KEY_VIBRATION_STRENGTH" is never used
Collaborator
|
Thank you for taking the time to submit a pull request!
@langerhans Please let us know your thoughts as well! |
Author
|
@miguelguzmanr Thanks a lot for the review, I've changed the option to be numeric instead for better customizability: |
There was a problem hiding this comment.
ktlint found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Added vibration option in App Overrides
This allows the user to select the vibration strength per app/game
This PR changes