fix(v2): quote identifiers in adelete and metadata filters#302
Open
naveen9871 wants to merge 2 commits into
Open
fix(v2): quote identifiers in adelete and metadata filters#302naveen9871 wants to merge 2 commits into
naveen9871 wants to merge 2 commits into
Conversation
Collaborator
|
naveen9871 Could you please add test cases for this fix? |
Add tests/unit_tests/v2/test_identifier_quoting.py covering: Offline SQL-generation tests (no DB required): - TestAdeleteQuotingOffline: verifies adelete WHERE clause double-quotes the id_column for mixed-case, spaced, and reserved-word names - TestFilterClauseQuotingOffline: verifies _create_filter_clause double-quotes both the metadata JSON column and explicit metadata columns, including nested JSON paths Integration tests (require PostgreSQL): - TestIdentifierQuotingIntegration: end-to-end regression tests that create tables with mixed-case column names and confirm adelete and similarity_search with metadata filters work without SQL errors
Author
|
Thanks for the review! I've added unit tests covering the identifier quoting fix in the latest commit ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301