-
Notifications
You must be signed in to change notification settings - Fork 17
Initial add IBM DB2 vector store . #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes look good to me.
Hi @MateuszOssGit @Mateusz-Switala @ccurme . Could you please review this PR? @shaikhq From our IBM DB2 team has approved it. It should be ready for you to review. If I need to do anything, please let me know. Thank you! |
8 files left unchanged [ "." = "" ] || poetry run ruff check --select I --fix . All checks passed!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like CI was not enabled for the new library. I enabled it and added a placeholder test.
IMO, priorities are (in descending order):
- Get CI checks to pass (this will block merging)
- Get
make integration_test
to pass on CI (this will block release) - Incorporate the standard test suite for vector stores (this is optional but nice to have)
@ccurme Thanks for your comments. I tried to fix most of the problems in the CI, but I still saw lint problems. Do we have a command to fix them automatically? Do you see other issues I need to fix? Thanks. |
|
I was able to successfully format all required changes to linting successfully passed. @yiweiHeOSS @shaikhq Could you please check on my changes from PR above to verify if everything has been updated correctly with your requirements? |
@ccurme @MateuszOssGit Thank you so much for your help! It looks like this PR is good to review again. @MateuszOssGit, I only found one little thing that I changed. It looks like we can't |
Hi @ccurme @MateuszOssGit, I resolved all the comments. If everything is good, can you please approve the PR so we can deliver it? Thanks. cc @Mateusz-Switala |
Thank you for reviewing it @Mateusz-Switala @MateuszOssGit |
Hi @ccurme, could you approve this PR? Thanks. |
This PR adds a new folder under libs for the DB2 vector store langchain connector code, i.e., libs/langchain-db2.
Other companies are doing the same things for their vector store (e.g. Google, AWS and Azure). Thanks for @ccurme to give me some guidance about where to put the code and @MateuszOssGit gave me the access to this repo .
Later, I will create a package on Pypi of the vector store connector, i.e.
pip install langchain-db2
. Note that it should have no impact on the current packagepip install langchain-ibm
. I just need a separate directory libs/langchain-db2 to put open-source code.The major changes in this PR are in the files below: