another fix to jitterentropy build#43
Merged
yuvalif merged 1 commit intolancedb:mainfrom Apr 21, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the build configuration to make RPM-based builds succeed when the environment CFLAGS includes _FORTIFY_SOURCE, which can break jitterentropy (via aws-lc-sys).
Changes:
- Add a CMake option to strip
_FORTIFY_SOURCEfromCFLAGSwhen invokingcargo build. - Enable the new option in the AlmaLinux (RPM-based) GitHub Actions CI job.
- Remove the
.cargo/config.tomlattempt to overrideCFLAGS, since Cargo’s[env]does not override existing environment variables.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
CMakeLists.txt |
Adds STRIP_FORTIFY_SOURCE and wraps cargo build with cmake -E env to override CFLAGS. |
.github/workflows/ci.yml |
Enables -DSTRIP_FORTIFY_SOURCE=ON for the AlmaLinux build job. |
.cargo/config.toml |
Removes CFLAGS = "-U_FORTIFY_SOURCE" from Cargo config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
this should cover the case of an RPM build. The issue is that RPM's build macros set CFLAGS in the environment (including -D_FORTIFY_SOURCE=2). Cargo's [env] section in .cargo/config.toml does not override existing environment variables. Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
yuvalif
force-pushed
the
wip-fix-jitterentropy-build4
branch
from
9e2c45e to
e86cd4b
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yuvalif
added a commit
to ceph/ceph-ci
that referenced
this pull request
Apr 21, 2026
see: lancedb/lancedb-c#43 Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
yuvalif
added a commit
to ceph/ceph-ci
that referenced
this pull request
Apr 21, 2026
see: lancedb/lancedb-c#43 Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
yuvalif
added a commit
to ceph/ceph-ci
that referenced
this pull request
Apr 23, 2026
see: lancedb/lancedb-c#43 Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this should cover the case of an RPM build.
The issue is that RPM's build macros set CFLAGS in the environment (including -D_FORTIFY_SOURCE=2). Cargo's [env] section in .cargo/config.toml does not override existing environment variables.