This repository was archived by the owner on Aug 15, 2023. It is now read-only.
Open
Conversation
MalteLL
suggested changes
Nov 29, 2019
README.md
Outdated
Comment on lines
42
to
45
| ``` | ||
| activityPerformance(logName) | ||
| ``` | ||
| #### Example | ||
| ``` | ||
| activityPerformance("Incident_withImpactAttributes.csv") | ||
| activityPerformance(lanaURL, lanaToken, logId) | ||
| ``` | ||
|
|
||
| | .id | frequency | totalDuration | minDuration | maxDuration | avgDuration | standardDeviation| median | |
Contributor
There was a problem hiding this comment.
activityPerfomance is not really used anymore, I would just delete it from the readme
Comment on lines
+30
to
+36
| #### Example Usage | ||
| ```R | ||
| # With empty trace filter sequence | ||
| discoveredModel(lanaURL, lanaToken, logId) | ||
|
|
||
| # With non-empty trace filter sequence | ||
| discoveredModel(lanaURL, lanaToken, logId, traceFilterSequence = "trace sequence") |
Contributor
There was a problem hiding this comment.
Please add more documentation here about the different things that you receive through this call as well as listing all the default values and what they actually change. If you have questions about it, just let me know.
Comment on lines
+61
to
+71
| Optional Parameters: | ||
| * `zDimension` (default = 'null') | ||
| * `aggrLevel` (default = 'traces') | ||
| * `followers` (default = 'null') | ||
| * `type` (default = 'aggregation') | ||
| * `cache` (default = 'null') | ||
| * `maxValueAmount` (default = 5) | ||
| * `activityExclusionFilter` (default = '[]') | ||
| * `traceFilterSequence` (default = '[]') | ||
| * `limit` (default = 10) | ||
| * `page` (default = 1) |
Contributor
There was a problem hiding this comment.
Please explain what these default values actually do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.