Skip to content

♻️ Fix FutureWarning in CanCurate #2950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

♻️ Fix FutureWarning in CanCurate #2950

merged 1 commit into from
Jul 18, 2025

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Jul 16, 2025

Fixes #2944

@Zethson Zethson marked this pull request as ready for review July 16, 2025 14:54
@codecov Codecov
Copy link

codecov bot commented Jul 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.75%. Comparing base (dcea0f6) to head (aae3d41).
Report is 20 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2950      +/-   ##
==========================================
- Coverage   91.89%   89.75%   -2.14%     
==========================================
  Files          73       70       -3     
  Lines       11442     9882    -1560     
==========================================
- Hits        10515     8870    -1645     
- Misses        927     1012      +85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Zethson Zethson requested a review from Koncopd July 16, 2025 14:59
@github-actions GitHub Actions
Copy link

Deployment URL: https://dcb09a61.lamindb.pages.dev

@Zethson Zethson requested a review from namsaraeva July 18, 2025 11:24
namsaraeva
namsaraeva reviewed Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@namsaraeva namsaraeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zethson Zethson merged commit 07e7645 into main Jul 18, 2025
17 of 18 checks passed
@Zethson Zethson deleted the fix/future_warning branch July 18, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namsaraeva namsaraeva namsaraeva approved these changes

@Koncopd Koncopd Awaiting requested review from Koncopd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pandas replace FutureWarning in CanCurate
2 participants
@Zethson @namsaraeva