Skip to content

♻️ Improve CELLxGENE compatibility #2941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jul 21, 2025
Merged

♻️ Improve CELLxGENE compatibility #2941

merged 22 commits into from
Jul 21, 2025

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Jul 15, 2025 •
edited
Loading

  • Fixes saving of example small_dataset3_cellxgene to disk
  • Fixes CELLxGENE Schema 5.3.0 Gene ensembl version from 113 to 110
  • Adds missing columns to AnnData slots that are required by CELLxGENE

@codecov Codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.09%. Comparing base (dcea0f6) to head (aa221d2).
Report is 26 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2941      +/-   ##
==========================================
+ Coverage   91.89%   92.09%   +0.19%     
==========================================
  Files          73       74       +1     
  Lines       11442    11246     -196     
==========================================
- Hits        10515    10357     -158     
+ Misses        927      889      -38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 15, 2025 •
edited
Loading

Deployment URL: https://bd63805f.lamindb.pages.dev

@Zethson
🎨 Donor -> donor_id
ea8d499 
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson
🎨 Polish
f2b0e34 
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson Zethson marked this pull request as ready for review July 16, 2025 13:52
@Zethson
🎨 Add remaining features
9930d9e 
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson
🎨 Duplicate
7df123d 
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson
🎨 More docstring details
deb1334 
Signed-off-by: Lukas Heumos <[email protected]>
Zethson added 4 commits July 17, 2025 19:22
@Zethson
🎨 Typo
dce3d04 
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson
🎨 Add init
cdc4d55 
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson
🎨 Fix test
ffacff3 
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson
🎨 Replace
69a34ea 
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson
🎨 Docs
add21f2 
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson
🎨 Fix docs
b461944 
Signed-off-by: Lukas Heumos <[email protected]>
@Zethson Zethson requested a review from sunnyosun July 18, 2025 15:57
sunnyosun
sunnyosun approved these changes Jul 20, 2025
View reviewed changes
Copy link
Member

@sunnyosun sunnyosun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Zethson Zethson merged commit 370dd76 into main Jul 21, 2025
34 of 47 checks passed
@Zethson Zethson deleted the feature/cellxgene_compat branch July 21, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunnyosun sunnyosun sunnyosun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zethson @sunnyosun