Skip to content

🚸 Restrict "column 'col' not in dataframe" error to at most 10 columns #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

🚸 Restrict "column 'col' not in dataframe" error to at most 10 columns #2549

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
215e61f
✨ Improve col not found error message
Zethson Mar 10, 2025
7707a84
🎨 Fix tests
Zethson Mar 11, 2025
a63a7a0
🎨 Polish
Zethson Mar 11, 2025
08a038f
Merge branch 'main' into feature/df_not_col_msg
Zethson Mar 11, 2025
d654e21
🎨 Polish
Zethson Mar 11, 2025
be56055
Merge branch 'feature/df_not_col_msg' of https://github.com/laminlabs…
Zethson Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lamindb/curators/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,8 +402,18 @@ def validate(self) -> None:
self._cat_manager_validate()
except pandera.errors.SchemaError as err:
self._is_validated = False
err_msg = str(err)

# Reduce Pandera validation stdout for many columns
if "column" in err_msg and "not in dataframe" in err_msg:
missing_col = err_msg.split("column '")[1].split("'")[0]
display_cols_str = _format_values(
list(self._dataset.columns), n=10, quotes=True, sep="'"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be simplified to display_cols_str = _format_values(self._dataset.columns, n=10)?

)
err_msg = f"column '{missing_col}' not in dataframe. {len(list(self._dataset.columns))} columns in dataframe including: {display_cols_str}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

err_msg = f"column '{missing_col}' not in dataframe. {len(list(self._dataset.columns))} columns in dataframe: {display_cols_str}"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if more than 1 columns are not in dataframe?


# .exconly() doesn't exist on SchemaError
raise ValidationError(str(err)) from err
raise ValidationError(err_msg) from err
else:
self._cat_manager_validate()

Expand Down