Pin PyPI publishing workflow actions#11
Open
lamenting-hawthorn wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow now grants only ChangesRelease workflow security
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
id-token: writeat workflow scope and referenced mutable action refs, creating a supply-chain risk for PyPI trusted publishing.Description
.github/workflows/release.ymlto remove the top-levelid-token: writeworkflow permission and keepid-token: writeonly in thepublish-pypijob.actions/download-artifact@v4with a pinned commit SHAactions/download-artifact@d3f86a106a0bac45b974a628896c90dbdf5c8093.pypa/gh-action-pypi-publish@release/v1with a pinned commit SHApypa/gh-action-pypi-publish@cef221092ed1bacb1cc03d23a2d87d1d172e277bwhile preserving the original job inputs.Testing
python - <<'PY' ... PY) that asserts allpublish-pypiuses:refs are 40-character SHA pins and thatid-token: writeis scoped to the publishing job, and the validator completed successfully.publish-pypijob still containingid-token: writeand no global OIDC permission present.Codex Task
Summary by CodeRabbit