-
Notifications
You must be signed in to change notification settings - Fork 0
Add stop behaviour to GenServer #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juan518munoz
wants to merge
7
commits into
stream_listener
Choose a base branch
from
reimpl_cancellation_token
base: stream_listener
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 4, 2025
fedacking
approved these changes
Jul 7, 2025
ElFantasma
reviewed
Jul 8, 2025
let join_handle = rt::spawn(async move { | ||
let _ = select( | ||
// Timer action is ignored if it was either cancelled or the associated GenServer is no longer running. | ||
let cancel_conditions = select( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice! I like having both, the individual cancellation_token, and the gen_server associated one
Good work! Also, I think that
Does it make sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
CancellationToken
to our Actors.Idea behind is that we can now
stop
all the running services working around an actor (timers and listeners as of now) when requested, so they are not left hanging.Note: this PR has no changes to the threads impl due to being no longer maintained, and should only be merged after stream listener PR.
Closes #18