test(levm,l1): run state tests as if they were blocks instead of transactions #4179

JereSalo · 2025-08-27T13:57:58Z

Motivation

The final goal is to run state tests with SP1, that's why we need to run them as blocks. This is a first step in that direction.

Description

Fix sign_inplace for Legacy Transactions.
Remove code that checks that withdrawal request and consolidation request accounts have code. This breaks 2 tests but it's completely worth it I'd say. It is an unrealistic case that doesn't happen in mainnet nor testnets.
- Geth skips these tests too
- I had to remove this because in the state tests scenarios these accounts don't exist.
I had to skip HighGasPrice EFTests because we need to fix the gas price for our Legacy and Type 1 transactions, it should be U256 L1: Use 256 bits for gas price in legacy transaction #3629
Now we accurately get the transaction from a test case, without doing the shady stuff we were previously doing.
- We also sign the transaction with the private key of the sender because it has to be valid.
Corrects all kinds of things we were doing wrong because when running the transaction only we didn't have problems. For example, make an accurate Genesis block. (Which wasn't very trivial I'd say)

Closes #4183

Co-authored-by: Copilot <[email protected]>

github-actions · 2025-08-27T14:01:17Z

Lines of code report

Total lines added: 290
Total lines removed: 50
Total lines changed: 340

Detailed view

+--------------------------------------------------------------+-------+------+
| File                                                         | Lines | Diff |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/l2/networking/rpc/signer.rs                    | 213   | +1   |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/vm/backends/levm/mod.rs                        | 464   | -12  |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/vm/backends/revm/mod.rs                        | 538   | -25  |
+--------------------------------------------------------------+-------+------+
| ethrex/crates/vm/errors.rs                                   | 127   | -2   |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/blockchain/deserialize.rs            | 124   | -5   |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/blockchain/test_runner.rs            | 365   | -5   |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/blockchain/types.rs                  | 466   | -1   |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/state_v2/src/main.rs                 | 26    | +4   |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/state_v2/src/modules/block_runner.rs | 142   | +142 |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/state_v2/src/modules/error.rs        | 9     | +1   |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/state_v2/src/modules/mod.rs          | 9     | +1   |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/state_v2/src/modules/parser.rs       | 96    | +2   |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/state_v2/src/modules/runner.rs       | 213   | +65  |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/state_v2/src/modules/types.rs        | 476   | +68  |
+--------------------------------------------------------------+-------+------+
| ethrex/tooling/ef_tests/state_v2/src/modules/utils.rs        | 44    | +6   |
+--------------------------------------------------------------+-------+------+

Copilot

Pull Request Overview

This PR implements the ability to run state tests as blocks instead of transactions to prepare for SP1 integration. The changes include transaction type refinements, system contract validation removal, and proper transaction signing.

Refactors transaction creation to accurately handle different transaction types (Legacy, EIP2930, EIP1559, EIP4844, EIP7702)
Removes system contract empty code validation checks that break state tests
Implements proper transaction signing with sender's private key

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tooling/ef_tests/state_v2/src/modules/utils.rs	Updates load_initial_state to accept fork parameter
tooling/ef_tests/state_v2/src/modules/types.rs	Adds chain config generation and genesis creation from test and fork
tooling/ef_tests/state_v2/src/modules/runner.rs	Refactors transaction creation and adds proper signing
tooling/ef_tests/state_v2/src/modules/block_runner.rs	New module for running tests as blocks
tooling/ef_tests/state_v2/src/main.rs	Adds feature flag to switch between transaction and block runners
crates/l2/networking/rpc/signer.rs	Fixes Legacy transaction signature recovery ID calculation
crates/vm/backends/revm/mod.rs	Removes system contract empty code validation
crates/vm/backends/levm/mod.rs	Removes system contract empty code validation
crates/blockchain/blockchain.rs	Makes get_total_blob_gas function public

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-29T19:43:57Z

tooling/ef_tests/state_v2/src/modules/types.rs

+    if *fork < Fork::Paris {
+        panic!("We don't support pre Merge forks, what are you doing here?");


The panic message is unprofessional and unhelpful. Replace with a descriptive error message that explains the limitation and suggests alternatives.

Suggested change

if *fork < Fork::Paris {

panic!("We don't support pre Merge forks, what are you doing here?");

panic!("Pre-Merge forks are not supported in this context. Please use a fork at or after Paris (the Merge).");

Copilot · 2025-08-29T19:43:57Z

tooling/ef_tests/state_v2/src/modules/types.rs

+        base_fee_per_gas: (test.env.current_base_fee.unwrap().as_u64()
+            * BASE_FEE_MAX_CHANGE_DENOMINATOR as u64)
+            .checked_div(7), // This was VERY carefully calculated so that the header passes validations in calculate_base_fee_per_gas


The comment mentions "VERY carefully calculated" but doesn't explain the calculation rationale. Replace with a clear explanation of why this specific formula is needed for header validation.

Suggested change

base_fee_per_gas: (test.env.current_base_fee.unwrap().as_u64()

* BASE_FEE_MAX_CHANGE_DENOMINATOR as u64)

.checked_div(7), // This was VERY carefully calculated so that the header passes validations in calculate_base_fee_per_gas

.checked_div(7), // The base fee per gas in the genesis block must be set so that, after applying the base fee adjustment logic (as defined in EIP-1559 and implemented in `calculate_base_fee_per_gas`), the resulting base fee matches the expected value for the first block. The division by 7 is chosen to reverse the protocol's adjustment formula, ensuring the header passes validation according to the Ethereum specification.

Copilot · 2025-08-29T19:43:58Z

tooling/ef_tests/state_v2/src/modules/runner.rs

+            gas: test_case.gas,
+            to: match to {
+                TxKind::Call(to) => to,
+                TxKind::Create => return Err(RunnerError::EIP7702ShouldNotBeCreateType), //TODO: See what to do with this. Maybe we want to get rid of the error and skip the test.


This TODO comment indicates unresolved design decisions. Either implement the proper handling or create a tracking issue and reference it in the comment.

Suggested change

TxKind::Create => return Err(RunnerError::EIP7702ShouldNotBeCreateType), //TODO: See what to do with this. Maybe we want to get rid of the error and skip the test.

TxKind::Create => return Err(RunnerError::EIP7702ShouldNotBeCreateType), // TODO: See https://github.com/your-org/your-repo/issues/1234 for discussion on how to handle this case (skip test or error).

Copilot · 2025-08-29T19:43:58Z

tooling/ef_tests/state_v2/src/modules/runner.rs

+    } else if !test_case.access_list.is_empty() {
+        // TODO: This will work, ideally Vec<something> should be Option<Vec<something>> so that we can tell if the field exists or not...


This TODO comment indicates a design limitation in the API. The current logic may incorrectly classify transactions with empty access lists. Consider implementing proper Optional handling or create a tracking issue.

Copilot · 2025-08-29T19:43:58Z

tooling/ef_tests/state_v2/src/modules/block_runner.rs

+        receipts_root: compute_receipts_root(&receipts),
+        logs_bloom: Default::default(),
+        difficulty: U256::zero(),
+        number: 1, // I think this is correct


The comment "I think this is correct" indicates uncertainty. Either verify this is the correct block number or document why this value is appropriate for state tests.

Suggested change

number: 1, // I think this is correct

number: 1, // In Ethereum state tests, the block being constructed is always the first block after genesis, which has block number 1.

JereSalo and others added 30 commits August 21, 2025 18:25

run tests with sp1

85cb3ff

make progress organizing tests

28ab1ea

make test runner simpler

36494f3

add test sp1 make target

0875f3e

organize tests a little bit more

3f99230

Merge branch 'main' into blockhain_tests_sp1

356228f

clippy lint

fa178b4

fix problems runner

fb3e3a9

improve todo comments

240a216

Update cmd/ef_tests/blockchain/test_runner.rs

6745f04

Co-authored-by: Copilot <[email protected]>

tidy a little bit

d342ee5

merge

e9877f0

Delete cmd/ef_tests/state_v2/success_report.txt

78915d5

first iteration for running tests (doesnt work)

3c51655

make some progress in transaction signing

70d5ca7

change gas price for the vm not to fail validation

0614b0e

comment withdrawals stuff

961167f

Merge branch 'main' into blockhain_tests_sp1

79c5d04

merge main

9836c16

merge main

beda446

differentiate transactions correctly in tests

fbdbc98

fix recovery id on legacy txs

b3b590d

try use test.env fields instead of LEVM Environment

e63157b

set headers properly

c4ececd

fix problems with headers and gas fees (at least some of them)

5209d88

fix some other tests

5614edd

skip some tests for high gas price

76e6007

fix blob gas problem on type 3 transactions

5e7b030

fix for mistake

f97ffb3

remove system contract empty check

65d6465

JereSalo self-assigned this Aug 27, 2025

JereSalo added levm Lambda EVM implementation L1 Ethereum client labels Aug 27, 2025

github-project-automation bot added this to ethrex_l1 Aug 27, 2025

ethrex-project-sync bot moved this to In Progress in ethrex_l1 Aug 27, 2025

JereSalo added 3 commits August 27, 2025 11:15

remove a comment and fix some lints

9e9768e

skip system contract deployment tests

9a1ff3d

fix lint

6e5bb30

Base automatically changed from blockhain_tests_sp1 to main August 27, 2025 14:33

JereSalo added 13 commits August 27, 2025 11:52

tidy more the code

801d6eb

allow clippy all

cff62d4

merge main

b57df19

remove comment

2611f72

run cargo fmt

147f279

rename single_block_run to run_test

ac735a5

prevrandao from test.env

3cf7a72

run tests that fail too

89a8679

improve code

3d9501f

change some lines

1fe6bec

return custom error instead

ee312e7

remove print

986fa17

skip other tests

2af3cfb

JereSalo marked this pull request as ready for review August 27, 2025 19:55

JereSalo requested a review from a team as a code owner August 27, 2025 19:55

ethrex-project-sync bot moved this from In Progress to In Review in ethrex_l1 Aug 27, 2025

JereSalo requested a review from mpaulucci August 28, 2025 14:07

Merge branch 'main' into state_tests_sp1

772d890

Copilot AI review requested due to automatic review settings August 29, 2025 19:42

Copilot AI reviewed Aug 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(levm,l1): run state tests as if they were blocks instead of transactions #4179

test(levm,l1): run state tests as if they were blocks instead of transactions #4179

Uh oh!

JereSalo commented Aug 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 27, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 29, 2025

Uh oh!

Copilot AI Aug 29, 2025

Uh oh!

Copilot AI Aug 29, 2025

Uh oh!

Copilot AI Aug 29, 2025

Uh oh!

Copilot AI Aug 29, 2025

Uh oh!

Uh oh!

		if *fork < Fork::Paris {
		panic!("We don't support pre Merge forks, what are you doing here?");

	if *fork < Fork::Paris {
	panic!("We don't support pre Merge forks, what are you doing here?");
	panic!("Pre-Merge forks are not supported in this context. Please use a fork at or after Paris (the Merge).");

	TxKind::Create => return Err(RunnerError::EIP7702ShouldNotBeCreateType), //TODO: See what to do with this. Maybe we want to get rid of the error and skip the test.
	TxKind::Create => return Err(RunnerError::EIP7702ShouldNotBeCreateType), // TODO: See https://github.com/your-org/your-repo/issues/1234 for discussion on how to handle this case (skip test or error).

		} else if !test_case.access_list.is_empty() {
		// TODO: This will work, ideally Vec<something> should be Option<Vec<something>> so that we can tell if the field exists or not...

	number: 1, // I think this is correct
	number: 1, // In Ethereum state tests, the block being constructed is always the first block after genesis, which has block number 1.

test(levm,l1): run state tests as if they were blocks instead of transactions #4179

Are you sure you want to change the base?

test(levm,l1): run state tests as if they were blocks instead of transactions #4179

Uh oh!

Conversation

JereSalo commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Aug 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Lines of code report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JereSalo commented Aug 27, 2025 •

edited

Loading

github-actions bot commented Aug 27, 2025 •

edited

Loading