feat(l1): add prune-blocks tool
#4138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines of code reportTotal lines added: Detailed view |
MegaRedHand
reviewed
Aug 25, 2025
| .map_err(StoreError::LibmdbxError)? | ||
| else { | ||
| // Block must have been already purged | ||
| txn.commit().map_err(StoreError::LibmdbxError)?; |
There was a problem hiding this comment.
Do we need to commit here? Can't we just abort or discard the tx?
There was a problem hiding this comment.
I had some problems because of this when testing it
Comment on lines
+345
to
+355
| // Remove transaction location and receipts. Note that if the block was obtained via snap sync these are not guaranteed to exist | ||
| for (idx, tx_hash) in block_body | ||
| .transactions | ||
| .iter() | ||
| .map(|tx| tx.hash()) | ||
| .enumerate() | ||
| { | ||
| txn.delete::<TransactionLocations>(tx_hash.into(), None) | ||
| .map_err(StoreError::LibmdbxError)?; | ||
| txn.delete::<Receipts>((block_hash, idx as u64).into(), None) | ||
| .map_err(StoreError::LibmdbxError)?; |
There was a problem hiding this comment.
If these aren't guaranteed to exist, should we ignore any errors then?
There was a problem hiding this comment.
We don't get an error if they don't exist
tooling/prune-blocks/src/README.md
Outdated
|
|
||
| The tool takes two optional arguments: | ||
| *`datadir`: The path to the DB location, will use the default one if not provided | ||
| *`blocks_to_keep`: The amount of latest blocks that will be kept in the DB. This value must be al least 128 and lower than the current amount of blocks in the chain. |
There was a problem hiding this comment.
Suggested change
| *`blocks_to_keep`: The amount of latest blocks that will be kept in the DB. This value must be al least 128 and lower than the current amount of blocks in the chain. | |
| *`blocks_to_keep`: The number of latest blocks that will be kept in the DB. This value must be at least 128 and lower than the current number of blocks in the chain. |
There was a problem hiding this comment.
I prefer amount instead of number as number could be confused with an actual block number (aka keep blocks in store as of block number X instead of keeping X amount of blocks from the latest). Fixed the typo
Co-authored-by: Tomás Grüner <[email protected]>
Co-authored-by: Tomás Grüner <[email protected]>
Co-authored-by: Tomás Grüner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Ethrex nodes can get pretty heavy. In order to lower the space of the DB when full syncing large networks this PR proposes adding a
prune-blockstool which will remove old blocks and their associated data.Description
prune-blockstoolCloses #issue_number