Skip to content

perf(levm): add sstore bench, allow unoptimized bench contracts and improve bench makefile #3552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf(levm): add sstore bench, allow unoptimized bench contracts and improve bench makefile #3552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion crates/vm/levm/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
.PHONY: all test clippy fmt usage lint eth-tests run-evm-ef-tests flamegraph-run-ef-tests samply-run-ef-tests render-benches
.PHONY: all test clippy fmt usage lint eth-tests run-evm-ef-tests flamegraph-run-ef-tests samply-run-ef-tests render-benches samply-run-bench

all: test clippy fmt ## 🚀 Runs all tests, linter and formatter

Expand Down Expand Up @@ -38,6 +38,7 @@ BENCH_TRANSFER_ITERATIONS := 500
BENCH_APPROVAL_ITERATIONS := 500
BENCH_PUSH_ITERATIONS := 0 # unused, fixed size array to use stack
BENCH_MSTOREBENCH_ITERATIONS := 0 # unused, fixed size array to use stack
BENCH_SSTOREBENCH_ITERATIONS := 0 # unused, fixed size array to use stack

# For manually testing you could add --show-output to hyperfine
define run_benchmark
Expand Down Expand Up @@ -77,6 +78,7 @@ compile-contracts:

revm-comparison: compile-contracts ## 📊 Run benchmarks of fibonacci and factorial for both REVM and LEVM
$(MAKE) build-revm-comparison
$(call run_benchmark,SstoreBench_no_opt,REPETITIONS_SLOW,BENCH_SSTOREBENCH_ITERATIONS)
$(call run_benchmark,MstoreBench,REPETITIONS,BENCH_MSTOREBENCH_ITERATIONS)
$(call run_benchmark,Fibonacci,REPETITIONS,BENCH_FIB_ITERATIONS)
$(call run_benchmark,FibonacciRecursive,REPETITIONS_SLOW,BENCH_FIB_REC_ITERATIONS)
Expand All @@ -97,6 +99,7 @@ revm-comparison-ci: compile-contracts
$(call run_benchmark_ci,FactorialRecursive,REPETITIONS,BENCH_FACT_ITERATIONS)
$(call run_benchmark_ci,Push,REPETITIONS,BENCH_PUSH_ITERATIONS)
$(call run_benchmark_ci,MstoreBench,REPETITIONS,BENCH_MSTOREBENCH_ITERATIONS)
$(call run_benchmark_ci,SstoreBench_no_opt,REPETITIONS_SLOW,BENCH_SSTOREBENCH_ITERATIONS)
$(call run_benchmark_ci,ManyHashes,REPETITIONS_SLOW,BENCH_HASHES_ITERATIONS)
$(call run_benchmark_ci,BubbleSort,REPETITIONS_SLOW,BENCH_BUBBLESORT_ITERATIONS)
$(call run_benchmark_ci,ERC20Approval,REPETITIONS_SLOW,BENCH_APPROVAL_ITERATIONS)
Expand Down Expand Up @@ -127,6 +130,11 @@ build-revm-comparison:
CARGO_TARGET_DIR=../../target \
cargo build --release --bin benchmark

build-revm-comparison-debuginfo:
cd bench/revm_comparison && \
CARGO_PROFILE_RELEASE_DEBUG=1 CARGO_TARGET_DIR=../../target \
cargo build --release --bin benchmark

###### Build Client with LEVM ######
EFTEST_DIR := ../../../cmd/ef_tests/state
VECTORS_DIR := $(EFTEST_DIR)/vectors
Expand Down Expand Up @@ -161,3 +169,11 @@ flamegraph-run-ef-tests: ## 🔥 Run EF tests and create a flamegraph per test f
samply-run-ef-tests: ## ⚡️ Run EF tests and create a samply profiling file per test folder
cd $(EFTEST_DIR) && \
$(MAKE) samply-run-ef-tests

BENCH ?= *
BENCH_REPS ?= 500
BENCH_ITERS ?= 57

samply-run-bench: ## ⚡️ Runs the provided bench with samply Pass BENCH=Fibonacci to choose the benchmark.
$(MAKE) build-revm-comparison-debuginfo
samply record -r 10000 target/release/benchmark levm $(BENCH) $(BENCH_REPS) $(BENCH_ITERS)
Loading
Loading