Skip to content

[WIP] Merkle root paralelization #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Conversation

pablodeymo
Copy link
Contributor

Motivation

Description

Closes #issue_number

Copy link

github-actions bot commented Jul 7, 2025

Lines of code report

Total lines added: 538
Total lines removed: 9
Total lines changed: 547

Detailed view
+---------------------------------------------+-------+------+
| File                                        | Lines | Diff |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/branch.rs    | 525   | +3   |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/extension.rs | 431   | +1   |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/leaf.rs      | 269   | +3   |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/mod.rs       | 8     | +8   |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/node.rs      | 151   | +151 |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/node_hash.rs | 136   | +136 |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/node_ref.rs  | 82    | +82  |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/node/rlp.rs       | 123   | +123 |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/trie.rs           | 899   | -5   |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/trie_iter.rs      | 92    | -2   |
+---------------------------------------------+-------+------+
| ethrex/crates/common/trie/verify_range.rs   | 497   | -2   |
+---------------------------------------------+-------+------+
| ethrex/crates/storage/store.rs              | 1401  | +31  |
+---------------------------------------------+-------+------+

Copy link

github-actions bot commented Jul 7, 2025

Benchmark for 34a6172

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 38.7±3.03ms 36.5±1.68ms -5.68%
Trie/cita-trie insert 1k 3.7±0.04ms 3.8±0.20ms +2.70%
Trie/ethrex-trie insert 10k 56.4±1.65ms 54.9±0.55ms -2.66%
Trie/ethrex-trie insert 1k 6.4±0.03ms 6.4±0.15ms 0.00%

Copy link

github-actions bot commented Jul 7, 2025

Benchmark for 365419c

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 36.0±1.20ms 37.3±1.47ms +3.61%
Trie/cita-trie insert 1k 3.6±0.03ms 3.9±0.23ms +8.33%
Trie/ethrex-trie insert 10k 56.6±0.80ms 56.1±0.96ms -0.88%
Trie/ethrex-trie insert 1k 6.4±0.03ms 6.4±0.04ms 0.00%

Copy link

github-actions bot commented Jul 8, 2025

Benchmark for 38fb201

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 35.5±1.15ms 35.8±1.45ms +0.85%
Trie/cita-trie insert 1k 3.7±0.08ms 3.6±0.13ms -2.70%
Trie/ethrex-trie insert 10k 55.6±1.07ms 60.5±13.91ms +8.81%
Trie/ethrex-trie insert 1k 6.4±0.10ms 8.7±1.22ms +35.94%

Copy link

github-actions bot commented Jul 8, 2025

Benchmark for 5db15cd

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 34.9±0.52ms 35.0±0.44ms +0.29%
Trie/cita-trie insert 1k 3.7±0.05ms 3.7±0.17ms 0.00%
Trie/ethrex-trie insert 10k 54.3±0.40ms 78.0±13.60ms +43.65%
Trie/ethrex-trie insert 1k 6.5±0.06ms 8.7±1.22ms +33.85%

Copy link

github-actions bot commented Jul 8, 2025

Benchmark for 71ee613

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 40.5±2.88ms 35.4±1.17ms -12.59%
Trie/cita-trie insert 1k 3.7±0.07ms 3.7±0.23ms 0.00%
Trie/ethrex-trie insert 10k 59.6±2.04ms 87.5±12.21ms +46.81%
Trie/ethrex-trie insert 1k 6.5±0.05ms 9.4±1.02ms +44.62%

Copy link

github-actions bot commented Jul 8, 2025

Benchmark for c6a0663

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 35.9±1.82ms 36.4±1.64ms +1.39%
Trie/cita-trie insert 1k 3.6±0.04ms 3.7±0.15ms +2.78%
Trie/ethrex-trie insert 10k 55.0±0.39ms 58.3±14.06ms +6.00%
Trie/ethrex-trie insert 1k 6.3±0.25ms 5.9±0.39ms -6.35%

Copy link

Benchmark for 4881c15

Click to view benchmark
Test Base PR %
Trie/cita-trie insert 10k 36.4±1.01ms 37.1±1.50ms +1.92%
Trie/cita-trie insert 1k 3.6±0.04ms 3.7±0.16ms +2.78%
Trie/ethrex-trie insert 10k 55.1±0.64ms 76.8±16.19ms +39.38%
Trie/ethrex-trie insert 1k 6.4±0.02ms 5.9±0.34ms -7.81%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants