Skip to content

fix(l1,l2): eth client send blobs when calling eth_estimateGas #3540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2025
Merged

fix(l1,l2): eth client send blobs when calling eth_estimateGas #3540

merged 3 commits into from
Jul 8, 2025
+33 −3

Conversation

LeanSerra
Copy link
Contributor

Motivation

When calling eth_estimateGas to estimate the gas for the L2 commitment the call was reverting because the blob was not included in the call

Description

  • Add a function to add the blobs to a GenericTransaction
  • Add the field "blobs" to the request if the blobs field is not empty

@LeanSerra LeanSerra self-assigned this Jul 7, 2025
@LeanSerra LeanSerra requested a review from a team as a code owner July 7, 2025 19:22
@LeanSerra LeanSerra added L2 Rollup client L1 Ethereum client labels Jul 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025

Lines of code report

Total lines added: 25
Total lines removed: 0
Total lines changed: 25

Detailed view 
+-------------------------------------------------+-------+------+
| File                                            | Lines | Diff |
+-------------------------------------------------+-------+------+
| ethrex/crates/networking/rpc/clients/eth/mod.rs | 1339  | +25  |
+-------------------------------------------------+-------+------+

@LeanSerra LeanSerra changed the title fix(l1,l2): eth client send blobs when calling eth_estimateGas fix(l1,l2): eth client send blobs when calling eth_estimateGas Jul 7, 2025
@tomip01 tomip01 moved this to In Review in ethrex_l2 Jul 7, 2025
tomip01
tomip01 approved these changes Jul 8, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Jul 8, 2025
@LeanSerra @tomip01
fix typo
f40c307 
Co-authored-by: Tomás Paradelo <[email protected]>
@LeanSerra LeanSerra enabled auto-merge July 8, 2025 16:20
@LeanSerra LeanSerra added this pull request to the merge queue Jul 8, 2025
Merged via the queue into main with commit 752c20b Jul 8, 2025
26 checks passed
@LeanSerra LeanSerra deleted the send_blobs_when_estimating_tx branch July 8, 2025 16:46
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l2 Jul 8, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrchatruc jrchatruc jrchatruc approved these changes

@tomip01 tomip01 tomip01 approved these changes

Assignees

@LeanSerra LeanSerra

Labels
L1 Ethereum client L2 Rollup client
Projects
ethrex_l1
Status: Done
ethrex_l2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeanSerra @jrchatruc @tomip01