Skip to content

refactor(l1): replace rlpx listener functions with spawned implementation #3504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

refactor(l1): replace rlpx listener functions with spawned implementation #3504

wants to merge 18 commits into from
+72 −99

Conversation

juan518munoz
Copy link

@juan518munoz juan518munoz commented Jul 7, 2025 •
edited
Loading

Remove spawn_listener and spawn_broadcast_listener functions in favour of spawned's helper functions for its GenServers.

Note: this PR should not be merged until related spawned changes are available on a release.

Closes #3387

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 7, 2025 •
edited
Loading

Lines of code report

Total lines added: 0
Total lines removed: 22
Total lines changed: 22

Detailed view 
+--------------------------------------------------------+-------+------+
| File                                                   | Lines | Diff |
+--------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/server.rs | 689   | -22  |
+--------------------------------------------------------+-------+------+

@mpaulucci mpaulucci changed the title Replace rlpx listener funcitons with spawned implementation Replace rlpx listener functions with spawned implementation Jul 7, 2025
@juan518munoz
Copy link
Author

Verfified by running hive tests:

make run-hive-debug SIMULATION=devp2p TEST_PATTERN="*"

And also by running three nodes at once:
image

ElFantasma
ElFantasma approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@ElFantasma ElFantasma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Nice 🕶️

@juan518munoz juan518munoz marked this pull request as ready for review July 15, 2025 15:23
@juan518munoz juan518munoz requested a review from a team as a code owner July 15, 2025 15:23
@juan518munoz juan518munoz changed the title Replace rlpx listener functions with spawned implementation refactor(l1): replace rlpx listener functions with spawned implementation Jul 15, 2025
@github-actions github-actions bot added the L1 Ethereum client label Jul 15, 2025
LeanSerra
LeanSerra reviewed Jul 18, 2025
View reviewed changes
Cargo.toml Outdated
Comment on lines 106 to 107
# Changing the tag for spawned will break the TDX image build
# When updating it try to build the TDX image and update service.nix with the new hash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment still necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe not, let's remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeanSerra LeanSerra LeanSerra left review comments

@ElFantasma ElFantasma ElFantasma approved these changes

@fedacking fedacking fedacking approved these changes

@MegaRedHand MegaRedHand MegaRedHand approved these changes

Assignees

@juan518munoz juan518munoz

Labels
L1 Ethereum client
Projects
ethrex_l1
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Stream listener mechanism from spawned, once implemented
5 participants
@juan518munoz @ElFantasma @fedacking @LeanSerra @MegaRedHand