Skip to content

Refactor generics code to acomodate future trait generics #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

edg-l
Copy link
Collaborator

@edg-l edg-l commented Apr 8, 2025

Mainly changes the symbol resultion structs to improve usability and account for traits, since multiple methods with the same name may exist and may only be distinct by the trait they are implemented in.

This makes the code cleaner and more readable.

Copy link

github-actions bot commented Apr 8, 2025

Benchmarking (Linux) factorial

Compiling factorial (factorial.con)
Finished release in 33.440121ms
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 97.32 ms
Rust Result = 2432902008176640000 Time taken : 60.46 ms

Benchmarking (Linux) fib

Compiling fib (fib.con)
Finished release in 26.401217ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 136.70 ms
Rust Result = 6765 Time taken : 85.66 ms

@edg-l edg-l force-pushed the refactor_generics_traits branch from ccbf081 to f8db81b Compare April 8, 2025 11:57
Copy link

github-actions bot commented Apr 8, 2025

Benchmarking (macOS) factorial

Compiling factorial (factorial.con)
Finished release in 981.648959ms
Running 5000000 iterations
Using input value: 20
Concrete Result = 2432902008176640000 Time taken : 31.97 ms
Rust Result = 2432902008176640000 Time taken : 25.20 ms

Benchmarking (macOS) fib

Compiling fib (fib.con)
Finished release in 192.611166ms
Running 5000 iterations
Using input value: 20
Concrete Result = 6765 Time taken : 120.48 ms
Rust Result = 6765 Time taken : 115.29 ms

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 84.31373% with 48 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (4802a28) to head (b0d4e8d).

Files with missing lines Patch % Lines
src/ir/lowering/adts.rs 64.28% 20 Missing ⚠️
src/ir/lowering/mod.rs 86.88% 8 Missing ⚠️
src/ir/lowering/functions.rs 93.57% 7 Missing ⚠️
src/ir/lowering/lower.rs 77.41% 7 Missing ⚠️
src/driver/mod.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   56.29%   59.18%   +2.89%     
==========================================
  Files          25       26       +1     
  Lines        5516     5892     +376     
==========================================
+ Hits         3105     3487     +382     
+ Misses       2411     2405       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from trait_bounds_check to main April 10, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants