-
Notifications
You must be signed in to change notification settings - Fork 21
Add compile-examples job to CI #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Benchmarking (Linux) factorialCompiling factorial (factorial.con) Benchmarking (Linux) fibCompiling fib (fib.con) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 59.57% 59.57%
=======================================
Files 24 24
Lines 4848 4848
=======================================
Hits 2888 2888
Misses 1960 1960 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fa4c528
to
c822dc5
Compare
Benchmarking (macOS) factorialCompiling factorial (factorial.con) Benchmarking (macOS) fibCompiling fib (fib.con) |
We test the examples under tests/cases.rs, that said maybe i missed some. I think this is duplicating work, the cases.rs also checks the expected return value and output |
@edg-l I noticed that some examples where not working, so I created this PR to track them. Unlike rust tests, these workflows would test (only builds) all examples in the directory, helping us see which are outdated.
That said, the new job takes much longer than the current jobs, so maybe its not worth to merge it. I could add it as a script to the repository instead. It may come handy. What do you think? |
we should either remove those outdated ones or fix them, imho we already test them via rust code so this isn't as useful and looks like duplicating work a bit. |
Adds a
compile-examples
job to the CI that compiles all examples.This job can be set as non-required.
Questions: