-
Notifications
You must be signed in to change notification settings - Fork 47
Fix builtin counter difference #1270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark results Main vs HEAD.Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
Base
Head
|
Benchmarking resultsBenchmark for program
|
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
11.596 ± 0.059 | 11.515 | 11.682 | 2.28 ± 0.02 |
cairo-native (embedded AOT) |
5.120 ± 0.083 | 4.978 | 5.211 | 1.01 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.087 ± 0.039 | 5.032 | 5.137 | 1.00 |
Benchmark for program dict_snapshot
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
808.7 ± 9.1 | 799.3 | 829.9 | 1.00 |
cairo-native (embedded AOT) |
4900.4 ± 31.1 | 4860.8 | 4947.1 | 6.06 ± 0.08 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5015.5 ± 35.0 | 4977.6 | 5088.3 | 6.20 ± 0.08 |
Benchmark for program factorial_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.401 ± 0.038 | 5.345 | 5.493 | 1.01 ± 0.01 |
cairo-native (embedded AOT) |
5.336 ± 0.051 | 5.282 | 5.447 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5.353 ± 0.037 | 5.294 | 5.423 | 1.00 ± 0.01 |
Benchmark for program fib_2M
Open benchmarks
Command | Mean [s] | Min [s] | Max [s] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.126 ± 0.010 | 5.110 | 5.145 | 1.06 ± 0.00 |
cairo-native (embedded AOT) |
4.817 ± 0.018 | 4.793 | 4.841 | 1.00 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
4.878 ± 0.024 | 4.835 | 4.914 | 1.01 ± 0.01 |
Benchmark for program linear_search
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
830.4 ± 6.0 | 821.4 | 840.6 | 1.00 |
cairo-native (embedded AOT) |
4931.4 ± 38.4 | 4865.3 | 5007.5 | 5.94 ± 0.06 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5073.1 ± 28.2 | 5038.0 | 5122.6 | 6.11 ± 0.06 |
Benchmark for program logistic_map
Open benchmarks
Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
540.8 ± 6.4 | 532.3 | 554.3 | 1.00 |
cairo-native (embedded AOT) |
4971.0 ± 20.7 | 4950.1 | 5012.5 | 9.19 ± 0.12 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
5168.6 ± 27.7 | 5145.4 | 5215.1 | 9.56 ± 0.12 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
=======================================
Coverage 80.21% 80.21%
=======================================
Files 112 112
Lines 29880 29881 +1
=======================================
+ Hits 23967 23968 +1
Misses 5913 5913 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Before the range check addition was removes, but this was wrong. To be the same as the compiles, the range check builtin counter should be added by 3
This was done in #1277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist