-
Notifications
You must be signed in to change notification settings - Fork 194
Resolve constants by full path #2192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JulianGCalderon
wants to merge
20
commits into
2.x.y
Choose a base branch
from
resolve-constants-by-full-path
base: 2.x.y
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark Results for unmodified programs 🚀
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## store-idents-in-hints #2192 +/- ##
=========================================================
+ Coverage 96.66% 96.67% +0.01%
=========================================================
Files 103 103
Lines 43646 43825 +179
=========================================================
+ Hits 42191 42369 +178
- Misses 1455 1456 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
587f490
to
e1f7c8a
Compare
The python implementation takes the references, while our implementation doesn't allow taking references when it expects a constants. For this reason, the example doesn't work as is in our current implementation. To fix this, I changed the example to not receive the values as parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2191
Resolves constants by full path, instead of only constant name. Currently, we are matching the first constant that shares the name, ignoring the full path to the constant. This has undefined behaviour if multiple constants have the same name.
To properly implement the lookup of constants, we need access two new elements:
I've added a test that fails with the current implementation. This PR solves it.
Checklist