Skip to content

dev: make VirtualMachine::get_traceback_entries pub #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ksew1
Copy link

@ksew1 ksew1 commented Jun 18, 2025

Make VirtualMachine::get_traceback_entries pub

Description

Made VirtualMachine::get_traceback_entries so it can be used in starknet-foundry backtrace feature

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@gabrielbosio
Copy link
Collaborator

gabrielbosio commented Jun 18, 2025

Hi, @ksew1, thanks for contributing! I have some questions:

  • Why does Scarb need this function for the backtrace feature?
  • How does this feature currently work without this function?

Also, as a side note: The VM also defines get_traceback which might be sufficient.

@ksew1
Copy link
Author

ksew1 commented Jul 7, 2025

Hi, @ksew1, thanks for contributing! I have some questions:

* Why does Scarb need this function for the backtrace feature?

* How does this feature currently work without this function?

Also, as a side note: The VM also defines get_traceback which might be sufficient.

How does this feature currently work without this function?

This is how it is currently done

Why does Scarb need this function for the backtrace feature?

We need pc as we map them to function names and lines using annotations for compiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants