Supported set to pointers#64
Open
excavador wants to merge 1 commit intolalamove:masterfrom
Open
Conversation
…etcetera) but also to pointer types (*string, *bool, etcetera). It's very useful to distinguish missed in config value from present in config
10d8e30 to
8c4db8b
Compare
Author
|
Any updates? |
1 similar comment
Author
|
Any updates? |
Contributor
|
Adding pointer values for primitive types unnecessarily adds bloat and complexity to the code. |
Contributor
|
Can you provide a concrete example where this feature would be useful for you? |
Author
|
Any updates? |
Author
|
@nishaad78 Sometime you need to add "default values". |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 94.34% 90.91% -3.43%
==========================================
Files 29 29
Lines 1397 1453 +56
==========================================
+ Hits 1318 1321 +3
- Misses 44 97 +53
Partials 35 35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supported assign parsed value not only to value types (string, bool, etcetera) but also to pointer types (*string, *bool, etcetera). It's very useful to distinguish missed in config value from present in config