Allow changing of statuses of existing services#8
Open
brimstone wants to merge 2 commits intolair-framework:masterfrom
Open
Allow changing of statuses of existing services#8brimstone wants to merge 2 commits intolair-framework:masterfrom
brimstone wants to merge 2 commits intolair-framework:masterfrom
Conversation
Author
|
@tomsteele anything I can to do help land this? |
Contributor
|
sorry @brimstone im no longer involved in the project |
Author
|
@tomsteele thanks so much for the response. @djkottmann are you still involved with the project or can you point me to someone who is? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We ran into a problem where we were trying to change the status of service after it had been added to lair. This little bit of code needs to be moved.
Also in this PR, is a
go.modandgo.sumthat work go 1.11 and probably go 1.12.