-
Notifications
You must be signed in to change notification settings - Fork 297
RBT Various additions and improvements #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ow management so that other windows are correctly disabled
…perly extracted with the shader
…ng autodoc and autocomplete
… requirement of having the source git in XFEAT_PATH. This solution can still be used if torchhub fails.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general,
- Check if copyright headers are present
- Protect openmp usage with `#if defined(VISP_HAVE_OPENMP) in *.cpp files. Avoid openmp usage in *.h
- Remove useless empty lines
|
||
virtual FrameBufferProperties getBufferProperties() const = 0; | ||
virtual PointerTo<Texture> setupTexture(const FrameBufferProperties &fbp) const; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this useless empty line. One is enough
PointerTo<GraphicsOutput> getMainOutputBuffer() VP_OVERRIDE { return m_normalDepthBuffer; } | ||
|
||
bool isFastAndApproximateRendering() const { return m_fast; } | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this useless empty line. One is enough
virtual void initFromParent(PointerTo<WindowFramework> window); | ||
virtual void initFromParent(const vpPanda3DBaseRenderer &renderer); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this useless empty line. One is enough
void initFromParent(PointerTo<WindowFramework> window) VP_OVERRIDE; | ||
void initFromParent(const vpPanda3DBaseRenderer &renderer) VP_OVERRIDE; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this useless empty line. One is enough
); | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this useless empty line. One is enough
const vpImage<float> &depth = previousFrame.depth.getSize() == 0 ? frame.depth : previousFrame.depth; | ||
if (depth.getSize() > 0 && m_depthErrorTolerance > 0.f) { | ||
#pragma omp parallel for | ||
for (unsigned int i = top; i <= static_cast<unsigned int>(bottom); ++i) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm right, when using omp, when using unsigned int
compiler produces a warning. For me vars should be int
. To be confirmed
@@ -0,0 +1,64 @@ | |||
/* | |||
* ViSP, open source Visual Servoing Platform software. | |||
* Copyright (C) 2005 - 2024 by Inria. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2004 - 2025
@@ -0,0 +1,95 @@ | |||
/* | |||
* ViSP, open source Visual Servoing Platform software. | |||
* Copyright (C) 2005 - 2024 by Inria. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2005- 2025
m_depthMask.updateMask(frame, previousFrame, m_depth); | ||
mask.resize(m_color.getHeight(), m_color.getWidth()); | ||
|
||
#pragma omp parallel for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add protection
#if defined(VISP_HAVE_OPENMP)
Should be checked everywhere
|
||
const std::string vpPanda3DDepthCannyFilter::FRAGMENT_SHADER = | ||
"#version 330\n" | ||
"#define PI 3.1415926538\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no other way to define PI in shaders, for example using M_PI
?
This PR introduces new functionalities to the Render-Based Tracker:
General:
Masking:
Features:
Odometry:
Pose estimation:
Others:
Known issues: