-
Notifications
You must be signed in to change notification settings - Fork 2
fix(LINK-4201): proper configuration of key vaults #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Infrastructure as Code - Found 12 new potential violation(s) - Severity 🛑 HighExpand DetailsThe Lacework FortiCNAPP Infrastructure as Code (IaC) static analyzer evaluated infrastructure as code (IaC) files and identified the following security and compliance violations in the source branch. See summary in Lacework FortiCNAPP.
|
kirklandnuts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just had one question re: the key vault policy dependency that was removed
| count = var.global ? 1 : 0 | ||
| depends_on = [ | ||
| lacework_integration_azure_agentless_scanning.lacework_cloud_account, | ||
| azurerm_key_vault_access_policy.access_for_user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't we still need this in the case that we're not using an existing key vault?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shoot, good call. Let me update and test.
Summary
This resolves an escalation raised by an Azure AWLS customer -- they have an org policy that restricts the creation of new key vaults, and while we provide a variable to provide an existing key vault for AWLS to use, our current module ignores this variable and attempts to create a new key vault regardless.
This PR ensures that we actually use the existing key vault if configured to do so.
How did you test this change?
The customer actually made these changes themselves, confirmed that the issue was fixed, and then provided the necessary code changes back to us.
Issue
https://lacework.atlassian.net/browse/LINK-4201