Resolve encoding issues on GUI mode#28
Open
kwon0408 wants to merge 2 commits into
Open
Conversation
Avicennasis
added a commit
to Avicennasis/NiimPrintX
that referenced
this pull request
Apr 11, 2026
Adds explicit UTF-8 encoding to ImageMagick font list subprocess call. Fixes GUI crash on Korean Windows (and any non-ASCII locale). Upstream: labbots#28 by @kwon0408 Closes labbots#26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was found during resolving #26 that the GUI mode gets unable to run if the system has a font with non-ASCII characters on its name.
Specifying an encoding of
'utf8'tosubprocess.runfinding fonts in the system solved this problem.