feat: disable reopen form when vuln was handled by a VEX rule#827
Open
refoo0 wants to merge 1 commit into
Open
feat: disable reopen form when vuln was handled by a VEX rule#827refoo0 wants to merge 1 commit into
refoo0 wants to merge 1 commit into
Conversation
Signed-off-by: rafi <refaei.shikho@hotmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds UI logic to prevent reopening a dependency vulnerability via the manual “reopen” form when it was last handled automatically by a VEX rule, guiding users to adjust/remove the VEX rule instead.
Changes:
- Introduces
isLastEventVexRulederived state to detect whether the latest relevant event came from a VEX rule. - Updates the closed-vuln UI to show an explanatory message instead of the reopen form when
isLastEventVexRuleis true.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+361
to
+375
| const isLastEventVexRule = useMemo(() => { | ||
| if (!vuln || !vuln.events || vuln.events.length === 0) { | ||
| return false; | ||
| } | ||
| for (let i = vuln.events.length - 1; i >= 0; i--) { | ||
| if (vuln.events[i].type === "rawRiskAssessmentUpdated") { | ||
| continue; | ||
| } else if (vuln.events[i].createdByVexRule) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } | ||
| } | ||
| return false; | ||
| }, [vuln]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.