Skip to content

fix: remove duplicate navigation links in mobile menu#2012

Open
Suhani95 wants to merge 1 commit into
kyverno:mainfrom
Suhani95:fix/mobile-nav-duplication
Open

fix: remove duplicate navigation links in mobile menu#2012
Suhani95 wants to merge 1 commit into
kyverno:mainfrom
Suhani95:fix/mobile-nav-duplication

Conversation

@Suhani95
Copy link
Copy Markdown
Contributor

@Suhani95 Suhani95 commented May 12, 2026

Related issue

Fixes: #2011

This PR resolves a UI bug where navigation links were rendered twice within the mobile overlay. The duplication resulted from redundant component mounting in the mobile view logic.

Proposed Changes

  • Removed the duplicate menu by deleting the extra set of links so they only show once.
  • Fixed the click behavior to ensure the links properly close the menu and scroll the page.
  • Simplified the code so the mobile menu uses just one list of links instead of two.

Before image
IMG-20260513-WA0006(1)
After image
IMG-20260513-WA0007

Checklist

  • I have read the contributing guidelines.
  • I have inspected the website preview for accuracy.
  • I have signed off my issue.

Signed-off-by: Suhani <suhani4630@gmail.com>
@onasser1
Copy link
Copy Markdown
Contributor

@Suhani95 Great!

could you please provide "before vs after" screenshots of your changes?
it is always recommended before testing this locally anyway for maintainers

@Suhani95
Copy link
Copy Markdown
Contributor Author

Suhani95 commented May 12, 2026

@onasser1
I have updated the PR description with 'Before vs. After' screenshots to demonstrate the changes.
I'll make sure to include these by default in my future PRs to make the review process smoother!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Duplicate navigation links in mobile menu overlay

2 participants