chore: fix build nvlink allocator with nvcc #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,7 +20,7 @@ CPP_FILE=$(dirname $(readlink -f $0))/nvlink_allocator.cpp # get cpp file path, | |||
|
|
|||
| # Use nvcc or g++ based on flag | |||
| if [ "$USE_NVCC" = true ]; then | |||
| nvcc "$CPP_FILE" -o "$OUTPUT_DIR/nvlink_allocator.so" -shared -Xcompiler -fPIC -lcuda -I/usr/local/cuda/include | |||
| nvcc "$CPP_FILE" -o "$OUTPUT_DIR/nvlink_allocator.so" -shared -Xcompiler -fPIC -I/usr/local/cuda/include | |||
There was a problem hiding this comment.
Since we have CUDA in the env now, should we just use g++? The early compiled result of nvcc is not functioning well, not really sure about this version.
There was a problem hiding this comment.
we didn't have full cuda support in ci. and we tried to remove cuda refs, which broke the release (the pr i reverted). so change this to make ci happy.
There was a problem hiding this comment.
But the release workload in https://github.com/kvcache-ai/Mooncake/blob/main/.github/workflows/release.yaml#L71C1-L75C90 will use nvcc and produce a nvlink_allocator.so which is not functioning as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make release happy.