Fix/copy command overwrite #226
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
@hwcopeland im not sure why we would change the custom files location was there a reason besides organization? its just that would be breaking change for what feels like a meaningless change. |
Contributor
Author
|
It is mostly for organization. I feel it added confusion to how the custom files are handled. If felt unnecessary then this pull can just take a few of the changes to the manifests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had some issues with trying to get
custom_filesloaded correctly. It seems that they were being loaded into/home/custom_filesfor some reason. Instead I propose they are loaded into/home/cs2-modded-server/custom_files. Everything is working flawlessly on my end now. This should be reviewed and tested. Is anyone running in compose, as well as someone on k8s able to review and validate changes?Also updated the recommended minimum as 60gb PV got filled on install and had to jump through hoops to fix it.