Skip to content

Added possibility of getting tag name from different directory.#30

Open
PiotrSiatkowski wants to merge 3 commits intokurttheviking:masterfrom
PiotrSiatkowski:tag-dir-option
Open

Added possibility of getting tag name from different directory.#30
PiotrSiatkowski wants to merge 3 commits intokurttheviking:masterfrom
PiotrSiatkowski:tag-dir-option

Conversation

@PiotrSiatkowski
Copy link
Copy Markdown

Right now I can get branch name from different directory than my current working directory. Tag is often used alongside with the branch name, that's why it would be fine to have access to tag name from different repository as well.

In this PR I am passing directory string as a options.cwd parameter for child_proces.spawnSync method.
Method documentation is here

@kurttheviking
Copy link
Copy Markdown
Owner

@PiotrSiatkowski interesting; it looks like after merging in some prior PRs this change has some tests/conflicts that need to be resolved first

@andre-lima
Copy link
Copy Markdown

It seems to be due to @PiotrSiatkowski using ES6 syntax, that is not supported by Node 5 or lower.

Since these versions already reached End-of-Life ( https://github.com/nodejs/Release#release-schedule ) do you still want to support them @kurttheviking ?

@kurttheviking
Copy link
Copy Markdown
Owner

Yeah, I am open to refactoring in general and bumping the major. Then, just need to make it clear in the docs which Node version continues to be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants