Security: Unbounded response body read can lead to memory exhaustion#560
Open
tuanaiseo wants to merge 2 commits intokurtmckee:mainfrom
Open
Conversation
The HTTP client reads the entire remote body into memory via `response.content` with no maximum size checks. A malicious endpoint can return a very large payload and cause excessive memory usage or process termination (DoS). Affected files: http.py Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
for more information, see https://pre-commit.ci
Contributor
|
@tuanaiseo Please stop with the slop PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The HTTP client reads the entire remote body into memory via
response.contentwith no maximum size checks. A malicious endpoint can return a very large payload and cause excessive memory usage or process termination (DoS).Severity:
mediumFile:
feedparser/http.pySolution
Use streamed reads (
stream=True) with a strict maximum byte limit, abort when limit is exceeded, and propagate a controlled error state.Changes
feedparser/http.py(modified)Testing