WIP ci: Add renovate configuration#5
Conversation
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| "groupName": "Go dependencies" | ||
| } | ||
| ], | ||
| "constraints": { |
There was a problem hiding this comment.
The constraint is not required, because renovate tries to stay with the currently used golang version. This rule is only overwritten by security updates.
There was a problem hiding this comment.
On my fork it tried to bump the golang version anyway, see 0xFelix/virt-template#17. I suspect this is not working?
| }, | ||
| "postUpdateOptions": [ | ||
| "gomodTidy", | ||
| "gomodUpdateImportPaths" |
There was a problem hiding this comment.
According to my limited understanding of golang, the gomodUpdateImportPaths is only required on major updates, which is disabled in renovate by default.
| "gomodUpdateImportPaths" | ||
| ], | ||
| "ignorePaths": [ | ||
| "**/vendor/**" |
There was a problem hiding this comment.
I think this is already included in ":gitSignOff"
There was a problem hiding this comment.
https://docs.renovatebot.com/presets-default/#gitsignoff
Doesn't look like it?
| "require", | ||
| "indirect" | ||
| ], | ||
| "groupName": "Go dependencies" |
There was a problem hiding this comment.
According to my experience, before grouping the indirect updates, they have to be enabled by
{
"matchManagers": ["gomod"],
"matchDepTypes": ["indirect"],
"enabled": true
},
There was a problem hiding this comment.
Seems to work without enabling them a second time, see on my fork 0xFelix/virt-template#17
| "packageRules": [ | ||
| { | ||
| "matchManagers": [ | ||
| "gomod" |
There was a problem hiding this comment.
this rule is redundant, because gomod is the only enabled manager
There was a problem hiding this comment.
During test runs on my fork it also picked up other managers, e.g. for the Dockerfiles. Maybe that's related to the global configuration of renovate, i.e. it depends on the global config which managers are enabled by default?
| ], | ||
| "baseBranchPatterns": [ | ||
| "main", | ||
| "/^release-v([0-9]+\\.([0-9]+))$/" |
There was a problem hiding this comment.
the release branches should get only security updates. Would be interesting to learn how to express this.
| @@ -0,0 +1,48 @@ | |||
| { | |||
| "$schema": "https://docs.renovatebot.com/renovate-schema.json", | |||
There was a problem hiding this comment.
You can add "assigneesFromCodeOwners": true
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale |
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
|
/remove-lifecycle stale @dominikholler Are you still working on this? |
|
https://github.com/dominikholler/kubevirt-renovate/blob/9c1572510a92c55c152ad73c582cfd16a3f040d5/virt-template-renovate.json was used to generate #88 . An external bot like redhat-renovate-bot or the Renovate GitHub App are not suitable, because this repo requires calling custom actions in addition to the golang updates. I did not found an order of custom actions so that a single call of For now, there are multiple packages excluded to avoid an update of the golang version, or to avoid applciation code changes. Probably these packages could be updated, if the project would be updated to the new kubernetes and golang version manually. |
|
There has been no activity on this PR for 45 days. What you can do:
/lifecycle stale |
|
/close Superseded by #103 |
What this PR does / why we need it:
Add renovate configuration to automatically update dependencies.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: