fix(test): retry authz allow tests to handle RBAC cache propagation - #104
Conversation
0xFelix
left a comment
There was a problem hiding this comment.
That means the negative tests may pass because of this behavior? That's also not what we want. Is there a way to ensure the cache is synced before making the assertions?
a42b482 to
27c0265
Compare
assisted-by: Cursor Signed-off-by: rkishner <rkishner@redhat.com>
27c0265 to
4381b72
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 0xFelix The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/cherry-pick release-0.2 |
|
@0xFelix: new pull request created: #105 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
The three functional tests were flaky due to a race between
RoleBindingcreation and the Kubernetes RBAC authorize cache.Wraps the
createTemplateRequestcalls in Eventually to retry until the cache propagates.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Tracked in Jira: https://redhat.atlassian.net/browse/CNV-92283
Release note: