-
Notifications
You must be signed in to change notification settings - Fork 301
Tests: Replace functional tests for virt-default storage class selection with unit tests #3943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/retest-required |
Acedus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @alromeros, left a couple of comments but the general transition looks great!
Signed-off-by: Alvaro Romero <[email protected]>
Since we addded unit tests that cover this logic, we don't need these functional test anymore. Signed-off-by: Alvaro Romero <[email protected]>
4894ecb to
3f52665
Compare
|
/lgtm |
awels
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/hold
putting on hold to see if all the comments are addressed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: awels The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/unhold |
|
/test pull-containerized-data-importer-e2e-nfs |
|
@alromeros: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This PR removes several functional tests that verify whether the virt-default or the k8s default storage class is selected when creating a PVC/dv. These tests have historically been flaky and do not cover any functionality that cannot be tested through unit tests.
They are now replaced with equivalent unit tests.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note: