Skip to content

Conversation

@alromeros
Copy link
Member

@alromeros alromeros commented Oct 31, 2025

What this PR does / why we need it:

This PR removes several functional tests that verify whether the virt-default or the k8s default storage class is selected when creating a PVC/dv. These tests have historically been flaky and do not cover any functionality that cannot be tested through unit tests.

They are now replaced with equivalent unit tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 31, 2025
@coveralls
Copy link

coveralls commented Oct 31, 2025

Coverage Status

coverage: 58.84% (+0.09%) from 58.751%
when pulling 3f52665 on alromeros:replace-virt-default-functest
into 6de420b on kubevirt:main.

@alromeros
Copy link
Member Author

/retest-required

Copy link
Contributor

@Acedus Acedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alromeros, left a couple of comments but the general transition looks great!

Since we addded unit tests that cover this logic, we don't need these functional test anymore.

Signed-off-by: Alvaro Romero <[email protected]>
@alromeros alromeros force-pushed the replace-virt-default-functest branch from 4894ecb to 3f52665 Compare November 12, 2025 12:52
@Dsanatar
Copy link
Collaborator

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 12, 2025
Copy link
Member

@awels awels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/hold
putting on hold to see if all the comments are addressed.

@kubevirt-bot kubevirt-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2025
@arnongilboa
Copy link
Collaborator

/lgtm

@alromeros
Copy link
Member Author

/unhold
Unholding as all the conversations have been resolved.

@kubevirt-bot kubevirt-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 21, 2025
@Acedus
Copy link
Contributor

Acedus commented Nov 23, 2025

/test pull-containerized-data-importer-e2e-nfs

@kubevirt-bot
Copy link
Contributor

@alromeros: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-containerized-data-importer-e2e-nfs 3f52665 link true /test pull-containerized-data-importer-e2e-nfs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants