ECOPROJECT-4271 | fix: hint at vCenter permissions when schema validation detects missing data - #394
Open
Jos-Jerus wants to merge 2 commits into
Open
ECOPROJECT-4271 | fix: hint at vCenter permissions when schema validation detects missing data#394Jos-Jerus wants to merge 2 commits into
Jos-Jerus wants to merge 2 commits into
Conversation
…tion detects missing data System.Read/System.View privilege checks pass but VMware still returns incomplete inventory for under-privileged users (known VMware behavior). When MISSING_CLUSTER or NO_VMS fires after collection, append a hint suggesting the user verify read-only access to clusters and hosts. Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: yjacobi <yjacobi@redhat.com>
Jos-Jerus
requested review from
ronenav and
tupyy
and removed request for
a team
August 23, 2026 11:45
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…tion warnings detect missing infrastructure data Empty networks/hosts/datastores warnings now log with "(may indicate insufficient permissions)" suffix. VMware returns partial inventory without RBAC errors — same root cause as ECOPROJECT-4271. Co-Authored-By: Claude Code <noreply@anthropic.com> Signed-off-by: yjacobi <yjacobi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MISSING_CLUSTERorNO_VMSafter collection, append a hint suggesting the user verify vCenter read-only access to clusters and hostsSystem.Read/System.View) passes for under-privileged users because VMware silently returns partial inventory without an RBAC error — this is a known VMware behaviorWhat changed
Both v1 and v2
collector_work.go: whenresult.HasErrors()includesMISSING_CLUSTERorNO_VMS, the error message now includes:Context
QA tested with the privilege-check fix (PRs #339/#341) and the issue persists — the user has
System.Read/System.Viewbut VMware still returns empty cluster data. This matches Igor's earlier findings in the Slack thread and the MTV precedent.Test plan
🤖 Generated with Claude Code