Skip to content

chore: remove V1 support: delete api, handlers, services and e2e test - #373

Open
AvielSegev wants to merge 1 commit into
kubev2v:mainfrom
AvielSegev:remove-v1
Open

chore: remove V1 support: delete api, handlers, services and e2e test#373
AvielSegev wants to merge 1 commit into
kubev2v:mainfrom
AvielSegev:remove-v1

Conversation

@AvielSegev

Copy link
Copy Markdown
Collaborator

Signed-off-by: Aviel Segev asegev@redhat.com

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Too many files!

This PR contains 101 files, which is 1 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b49480cd-5d0e-4e03-a67a-948d720648a0

📥 Commits

Reviewing files that changed from the base of the PR and between 1349fa2 and e6825f3.

📒 Files selected for processing (101)
  • .github/workflows/e2e.yml
  • Makefile
  • api/v1/docs.go
  • api/v1/extension.go
  • api/v1/extension_test.go
  • api/v1/openapi.yaml
  • api/v1/spec.gen.cfg
  • api/v1/spec.gen.go
  • api/v1/types.gen.cfg
  • api/v1/types.gen.go
  • cmd/run.go
  • internal/config/config.go
  • internal/config/zz_generated.configuration.go
  • internal/handlers/v1/applications.go
  • internal/handlers/v1/applications_test.go
  • internal/handlers/v1/collector.go
  • internal/handlers/v1/collector_test.go
  • internal/handlers/v1/console.go
  • internal/handlers/v1/console_test.go
  • internal/handlers/v1/credentials.go
  • internal/handlers/v1/credentials_test.go
  • internal/handlers/v1/doc.go
  • internal/handlers/v1/export.go
  • internal/handlers/v1/export_test.go
  • internal/handlers/v1/forecaster.go
  • internal/handlers/v1/group.go
  • internal/handlers/v1/group_test.go
  • internal/handlers/v1/handlers.go
  • internal/handlers/v1/handlers_suite_test.go
  • internal/handlers/v1/inspector.go
  • internal/handlers/v1/inspector_test.go
  • internal/handlers/v1/inventory.go
  • internal/handlers/v1/inventory_test.go
  • internal/handlers/v1/rightsizing.go
  • internal/handlers/v1/rightsizing_test.go
  • internal/handlers/v1/validation.go
  • internal/handlers/v1/version.go
  • internal/handlers/v1/vms.go
  • internal/handlers/v1/vms_test.go
  • internal/server/doc.go
  • internal/services/alias.go
  • internal/services/v1/application.go
  • internal/services/v1/application_test.go
  • internal/services/v1/applications.json
  • internal/services/v1/collector.go
  • internal/services/v1/collector_test.go
  • internal/services/v1/collector_work.go
  • internal/services/v1/collector_work_test.go
  • internal/services/v1/console.go
  • internal/services/v1/console_test.go
  • internal/services/v1/credentials.go
  • internal/services/v1/credentials_test.go
  • internal/services/v1/doc.go
  • internal/services/v1/event.go
  • internal/services/v1/export.go
  • internal/services/v1/export_internal_test.go
  • internal/services/v1/export_test.go
  • internal/services/v1/forecast.go
  • internal/services/v1/forecast_stats_test.go
  • internal/services/v1/forecaster.go
  • internal/services/v1/forecaster_test.go
  • internal/services/v1/group.go
  • internal/services/v1/group_test.go
  • internal/services/v1/inspection_builder.go
  • internal/services/v1/inspection_builder_test.go
  • internal/services/v1/inspector.go
  • internal/services/v1/inspector_test.go
  • internal/services/v1/inventory.go
  • internal/services/v1/inventory_test.go
  • internal/services/v1/manager.go
  • internal/services/v1/manager_test.go
  • internal/services/v1/rightsizing.go
  • internal/services/v1/rightsizing_test.go
  • internal/services/v1/services_suite_test.go
  • internal/services/v1/strategy.go
  • internal/services/v1/strategy_vm.go
  • internal/services/v1/vddk.go
  • internal/services/v1/vddk_test.go
  • internal/services/v1/vm.go
  • internal/services/v1/vm_labels_test.go
  • internal/services/v1/vm_migration_exclusion_test.go
  • internal/services/v1/vm_test.go
  • internal/services/v2/credentials_test.go
  • internal/services/v2/manager.go
  • internal/services/v2/vm_labels_test.go
  • internal/services/v2/vm_migration_exclusion_test.go
  • internal/store/vm_filter_test.go
  • main.go
  • test/e2e-v1/doc.go
  • test/e2e-v1/main.go
  • test/e2e-v1/service/agent.go
  • test/e2e-v1/test_applications_endpoint.go
  • test/e2e-v1/test_groups_endpoint.go
  • test/e2e-v1/test_groups_inventory.go
  • test/e2e-v1/test_migration_exclusion.go
  • test/e2e-v1/test_migration_exclusion_group_inventory.go
  • test/e2e-v1/test_validation.go
  • test/e2e-v1/test_vm_labels.go
  • test/e2e-v1/test_vms_endpoint.go
  • test/e2e-v1/tests.go
  • test/e2e-v1/todo.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch remove-v1
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AvielSegev
AvielSegev force-pushed the remove-v1 branch 5 times, most recently from 8a0e051 to c70ba76 Compare August 6, 2026 07:21
@AvielSegev

Copy link
Copy Markdown
Collaborator Author

cc @tupyy @amalimov

When we need we can use this one

Signed-off-by: Aviel Segev <asegev@redhat.com>
@tupyy

tupyy commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

@AvielSegev let's wait a bit before removing v1. I want v2 to be fully mature.

@nirarg nirarg added the on-hold label Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants