-
Notifications
You must be signed in to change notification settings - Fork 209
fix: prevent sidebar panel from appearing on window resize #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Khushi Agrawal <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @khushiiagrawal. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a bug where the WecsDetailsPanel sidebar would unintentionally appear during window resize events even when no node was selected. The fix enhances the panel's positioning and visibility controls to ensure it remains completely off-screen and non-interactive when closed.
Key Changes:
- Improved off-screen positioning from
-80vwto-100vwto ensure complete panel concealment - Added interaction prevention via
pointerEventsandvisibilityproperties - Introduced
maxWidth: '600px'to improve UX on larger displays
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This is Already Solve In #2256 |
@adity1raut please read the issue and the PR, the issue is in the deployed workload This PR resolves the issue #2254 |
Signed-off-by: Khushi Agrawal <[email protected]>
Signed-off-by: Khushi Agrawal <[email protected]>
|
/cc PTAL @kunal-511 @btwshivam |
|
@khushiiagrawal: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only kubestellar members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
@khushiiagrawal Test if after adding 2-3 big helm charts |
|
Also, remove unwanted comments |
…stent Signed-off-by: Khushi Agrawal <[email protected]>
Screen.Recording.2025-11-28.at.10.56.22.PM.mov |
I have removed it. |
Description
Fixed an issue where the WecsDetailsPanel sidebar (containing "Summary" and "Edit" buttons) would unintentionally appear when reducing the browser window size below a certain breakpoint. The panel was sliding in from the right side even when no node was selected, causing UI disruption.
Related Issue
Fixes #2254
Changes Made
rightposition from-80vwto-100vwwhenisOpenis falsepointerEvents: 'none'to prevent interaction when panel is closedvisibility: hiddento ensure panel is not visible when closedmaxWidth: '600px'to limit panel width on larger screensChecklist
Please ensure the following before submitting your PR:
Screenshots or Logs (if applicable)
Screen.Recording.2025-11-21.at.10.57.11.PM.mov