-
Notifications
You must be signed in to change notification settings - Fork 57
replace glide to go mod #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
weiliang-ms
commented
Dec 13, 2022
- Replace glide to go mod.
- Bump golang from 1.11 to 1.19
change glide to go mod
change glide to go mod
|
/assign @LinuxSuRen |
github.com/kubesphere/s2irun/cmd -> s2irun/cmd
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: weiliang-ms The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LinuxSuRen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can test the GitHub actions locally with https://github.com/nektos/act
OK. I'll try. |
When I simulated the build using |
LinuxSuRen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/cc @chilianyi |
|
@weiliang-ms: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
