perf: Reduce allocations when creating metric families #2807
+11
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The metric family generates a series by using a
strings.Builderto write data into, and then converts the string into a byte slice. This causes extra allocations which are not needed since we can directly write into a byte slice.Benchmarks in CI show an improvement: https://github.com/kubernetes/kube-state-metrics/actions/runs/19236033135?pr=2807.
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Has no effect.
Which issue(s) this PR fixes: (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)Fixes #