-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Include maxParallelImagePulls field in Kubelet config #17755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include maxParallelImagePulls field in Kubelet config #17755
Conversation
|
Welcome @jaswdr! |
|
Hi @jaswdr. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/test pull-kops-e2e-cni-amazonvpc |
|
failing tests seem to be related to network issues, I'll retry once more before diving deeper. /retest |
|
Ok, I found the root cause, the endpoints used in the test are down at the moment because CloudFlare is having a bad day (see: https://www.cloudflarestatus.com), I will wait for CloudFlare to recover before retrying to run the tests. |
no worries |
|
CloudFlare seems to have recovered, rerunning tests /retest |
|
@jaswdr would you mind also squashing the commits? |
|
Sure 👍, will do it |
Just waiting for Github to recover to push it 😂 https://www.githubstatus.com |
43baad9 to
1ef0e59
Compare
hakman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jaswdr!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
I noticed that the maxParallelImagePulls is not exposed as a field in the KubeletConfigSpec, so I'm exposing it to allow users to configure this particular field to control how many parallel pulls can happen.
Relevant links: