-
Notifications
You must be signed in to change notification settings - Fork 945
Update CNAME from etcd.netlify.com to etcd.netlify.app #8785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update CNAME from etcd.netlify.com to etcd.netlify.app #8785
Conversation
Update www.etcd.io Netlify CNAME from `.com` to `.app`, which tracks with Netlify best practices documented here: https://answers.netlify.com/t/deprecating-automatic-com-redirects/115442
|
|
|
Welcome @publicfacingusername! |
|
Hi @publicfacingusername. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: publicfacingusername The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi, while looking into kubernetes/sig-security#172, I noticed a minor discrepancy in the etcd.io DNS config.
etcd.netlify.com will return a 404 as Netlify deprecated automatic redirects from
*.netlify.comsites to*.netlify.appsites in late March 2024. Details here. Also from that link is this quote:So it's important to note that name resolution still works fine and this PR doesn't necessarily fix anything. Rather, this change aligns with the pattern used across all other Netlify sites referenced in this repo and follows the vendor's recommendation.