Add distinct owners files to reflect the shared ownership of the repo #2997
+288
−16
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,8 @@ | ||
| approvers: | ||
| - general-maintainers | ||
| - l7-owners | ||
| - l4-neg-psc-owners | ||
|
Comment on lines
+3
to
+4
Contributor
There was a problem hiding this comment. I think that adding l7-owners and l4-neg-psc-owners to the root OWNERS file will cause other OWNERS files to inherit from their parent directories. My guess is that this change would make all groups owners of every subdirectory in the repository even if other directories specify a different config. From what I've seen ownership is additive by default so the OWNERS permissions from the parent directory are combined with the permissions in the subdirectory's OWNERS file. An owner in a parent directory is still an owner in a child directory. Might be worth checking since I can be wrong
Contributor
There was a problem hiding this comment. The solution might be to use |
||
| reviewers: | ||
| - general-maintainers | ||
| - l7-owners | ||
| - l4-neg-psc-owners | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| ### Code Ownership Structure | ||
|
|
||
| This document outlines the ownership structure for directories within `pkg/` and `cmd/glbc/`. Ownership is categorized into three groups: L7, L4_NEG_PSC, and Shared. The designated owners for each category can be found in the `L7_OWNERS`, `L4_NEG_PSC_OWNERS` and `OWNERS` files respectively. | ||
|
|
||
| #### 1. L7 Ownership | ||
|
|
||
| These directories contain code exclusive to the L7 Ingress controller. | ||
|
|
||
| * **`pkg/apis/backendconfig`**: Defines the `BackendConfig` CRD for L7 features. | ||
| * **`pkg/apis/frontendconfig`**: Defines the `FrontendConfig` CRD for L7 frontend configurations. | ||
| * **`pkg/backendconfig`**: Implements the `BackendConfig` CRD logic. | ||
| * **`pkg/controller`**: Contains the core reconciliation loop for the L7 Ingress controller. | ||
| * **`pkg/frontendconfig`**: Implements the `FrontendConfig` CRD logic. | ||
| * **`pkg/healthchecks`**, **`pkg/healthchecksprovider`**: Manages generic health check resources. | ||
| * **`pkg/metrics`**: Exposes L7 Prometheus metrics. | ||
| * **`pkg/translator`**: Translates Ingress/Service state into L7 load balancer configurations. | ||
| * **`pkg/utils/healthcheck`**: Used by `pkg/healthchecks` and `pkg/translator`. | ||
|
|
||
| #### 2. L4_NEG_PSC Ownership | ||
|
|
||
| These directories contain code exclusive to the L4 (Internal Load Balancer), NEG (Network Endpoint Group), and PSC (Private Service Connect) controllers. | ||
|
|
||
| * **`pkg/apis/serviceattachment`**: Defines the `ServiceAttachment` CRD for PSC. | ||
| * **`pkg/apis/svcneg`**: Defines APIs for Service NEGs, used by L4/NEG controllers. | ||
| * **`pkg/apis/providerconfig`**: Contains shared API types for cloud provider configuration. | ||
| * **`pkg/healthchecksl4`**: Manages health checks specifically for L4 load balancers. | ||
| * **`pkg/l4lb`**: Contains the core implementation of the L4 ILB controller. | ||
| * **`pkg/neg`**: Home of the NEG controller. | ||
| * **`pkg/multiproject`**: Shared logic for multi-project support. | ||
| * **`pkg/providerconfig`**: Shared cloud provider configuration. | ||
| * **`pkg/network`**: Provides network-related utilities for L4/NEG controllers. | ||
| * **`pkg/psc`**: Implements the Private Service Connect controller. | ||
| * **`pkg/serviceattachment`**: Implements the `ServiceAttachment` CRD logic. | ||
| * **`pkg/svcneg`**: Implements the Service NEG controller for L4 and standalone NEGs. | ||
| * **`pkg/utils/serviceattachment`**: Used by `pkg/psc`. | ||
|
|
||
| #### 3. Shared Ownership | ||
|
|
||
| These directories contain shared components, utilities, and abstractions used by all controllers. | ||
|
|
||
| * **`cmd/glbc`** and **`cmd/glbc/app`**: Main entrypoint for the controller binary. | ||
| * **`pkg/address`**: Manages shared IP address resources. | ||
| * **`pkg/annotations`**: Manages annotations for both Ingress and Service resources. | ||
| * **`pkg/backends`**: Provides common abstractions for managing backend services. | ||
| * **`pkg/backoff`**, **`pkg/ratelimit`**, **`pkg/throttling`**: Shared utilities for managing API calls. | ||
| * **`pkg/common`**: Collections of common data structures and helper functions. | ||
| * **`pkg/composite`**: Shared utilities for handling composite Google Cloud resources. | ||
| * **`pkg/context`**: Manages the shared controller context. | ||
| * **`pkg/crd`**: Shared logic for interacting with CRDs. | ||
| * **`pkg/e2e`**, **`pkg/fuzz`**, **`pkg/test`**: Shared testing infrastructure. | ||
| * **`pkg/events`**, **`pkg/recorders`**: Provides a standardized way to emit Kubernetes events. | ||
| * **`pkg/experimental`**: Contains experimental features not tied to a specific controller. | ||
| * **`pkg/firewalls`**: Manages firewall rules. | ||
| * **`pkg/flags`**: Defines and parses command-line flags. | ||
| * **`pkg/forwardingrules`**: Manages forwarding rules. | ||
| * **`pkg/instancegroups`**: Manages instance groups. | ||
| * **`pkg/klog`**: A shared logging wrapper. | ||
| * **`pkg/loadbalancers`**: Manages load balancer resources for both Ingress | ||
| and L4 controllers. | ||
| * **`pkg/nodetopology`**: Shared logic for node topology. | ||
| * **`pkg/storage`**: Shared storage utilities. | ||
| * **`pkg/sync`**: Contains the shared sync loop implementation. | ||
| * **`pkg/systemhealth`**: Shared system health monitoring. | ||
| * **`pkg/validation`**: Shared resource validation logic. | ||
| * **`pkg/version`**: Provides shared controller version information. | ||
| * **`pkg/utils/common`**: Used by both L4 and L7 controllers. | ||
| * **`pkg/utils/descutils`**: Used by `pkg/utils/healthcheck` (L7) and `pkg/utils/serviceattachment` (L4). | ||
| * **`pkg/utils/endpointslices`**: Used by `pkg/neg` (L4) and `pkg/controller/translator` (L7). | ||
| * **`pkg/utils/namer`**: Used by a wide variety of L4 and L7 components. | ||
| * **`pkg/utils/patch`**: Used by `pkg/neg` (L4), `pkg/psc` (L4), and `pkg/l4lb` (L4), and also by the shared `pkg/utils/common`. | ||
| * **`pkg/utils/slice`**: Used by `pkg/psc` (L4), `pkg/loadbalancers` (L7), and `pkg/firewalls` (shared). | ||
| * **`pkg/utils/zonegetter`**: Used by `pkg/neg` (L4), `pkg/l4lb` (L4), and `pkg/controller` (L7). | ||
|
|
||
| #### 4. Updating Owners | ||
|
|
||
| When an owners file is updated, please refer to this README to help understand which set of owners files need to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,17 @@ | ||||||||
| aliases: | ||||||||
| # Top-level project maintainers | ||||||||
| general-maintainers: | ||||||||
| - thockin | ||||||||
| - aojea | ||||||||
| - bowei | ||||||||
| - swetharepakula | ||||||||
| # Owners for L7 features (Ingress, BackendConfig, etc.) | ||||||||
| l7-owners: | ||||||||
| - kl52752 | ||||||||
| - DamianSawicki | ||||||||
| - spencerhance | ||||||||
| # Owners for L4/NEG/PSC features | ||||||||
| l4-neg-psc-owners: | ||||||||
| - mmamczur | ||||||||
| - tortillazhawaii | ||||||||
| - felipeyepez | ||||||||
|
Member
There was a problem hiding this comment. Enrico has received Kubernetes Membership. #3003
Suggested change
Member
There was a problem hiding this comment. It probably causes the merge conflict as well |
||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers | ||
|
Comment on lines
+1
to
+7
Member
There was a problem hiding this comment. L4 has most of the code here. I don't think there could be a single owner for this pkg, unless one side moves out from it |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L7 features | ||
| approvers: | ||
| - l7-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l7-owners | ||
| - general-maintainers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # approvers for L4/NEG/PSC features | ||
| approvers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
| reviewers: | ||
| - l4-neg-psc-owners | ||
| - general-maintainers | ||
|
Contributor
There was a problem hiding this comment. If my comment about ownership being additive is true we might not need to specify |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't strip
mrhohn,panslava,cezarygerard,code-elinka,gauravkghildiyal, andsawsa307of their privileges on the occasion of splitting ownership for distinct controllers. If some of these names are outdated, it can be handled in separate PRs with the relevant folks as reviewers.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good solution might be to use
emeritus_approvershttps://go.k8s.io/owners