KEP-6063: Update README to match Alpha implementation - #6258
Conversation
|
Hi @BhargaviGudi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: BhargaviGudi The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@SergeyKanzhelev @haircommander @mrunalp This updates the KEP README to reflect the current Alpha implementation in kubernetes/kubernetes#139277:
No functional changes; just aligning the KEP with implementation. |
|
/assign |
harche
left a comment
There was a problem hiding this comment.
Thanks for updating the KEP to match the implementation. One spot I could not attach an inline comment to because the line is outside the diff: the Risks item "Version skew: apiserver accepts but kubelet ignores" has the same outdated assumption as my comment on the Feature Gate section, with the fail closed admission the kubelet rejects the pod rather than silently applying the node default: https://github.com/kubernetes/kubernetes/blob/f050421a6693073df402fde0cc9f3568087c2d1e/pkg/kubelet/lifecycle/features_linux.go#L62-L70
|
/ok-to-test |
|
/test pull-enhancements-test |
472e73a to
ce9b942
Compare
- Resource name is pids (plural), not pid - Remove kubelet_pod_pid_limit_applied_total metric (deferred past Alpha) - Add PodLevelResourcesFixKubeletQOSClass as a required dependency - Clean up Valid Values section
ce9b942 to
8d8acea
Compare
|
LGTM. /hold until kubernetes/kubernetes#139277 merges, so that we can accommodate more amendments, should we need any more. |
What this PR does / why we need it
Updates the KEP-6063 README to align with the Alpha implementation in kubernetes/kubernetes#139277.
Changes
pid→pidsthroughout (API field, YAML examples, user stories, validation rules, tests, dependencies, drawbacks)kubelet_pod_pid_limit_applied_totalfrom Alpha graduation criteria, monitoring, and SLI sections; noted as deferred to Beta in "missing metrics"PodLevelResourcesFixKubeletQOSClass(Beta, enabled by default since v1.37) to Feature Gate and Dependencies sectionsDiscover()only checks the feature gate; cgroupsv1 incompatibility is handled by kubelet admissionmin()capping logic lives inEnsureExists, notgetPodPIDLimitRelated PRs
/sig node
/cc @haircommander @ngopalak-redhat