Skip to content

KEP-6063: Update README to match Alpha implementation - #6258

Open
BhargaviGudi wants to merge 1 commit into
kubernetes:masterfrom
BhargaviGudi:kep-6063-update-readme
Open

KEP-6063: Update README to match Alpha implementation#6258
BhargaviGudi wants to merge 1 commit into
kubernetes:masterfrom
BhargaviGudi:kep-6063-update-readme

Conversation

@BhargaviGudi

@BhargaviGudi BhargaviGudi commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

Updates the KEP-6063 README to align with the Alpha implementation in kubernetes/kubernetes#139277.

Changes

  • Resource name: pidpids throughout (API field, YAML examples, user stories, validation rules, tests, dependencies, drawbacks)
  • Metric deferred: Removed kubelet_pod_pid_limit_applied_total from Alpha graduation criteria, monitoring, and SLI sections; noted as deferred to Beta in "missing metrics"
  • New dependency: Added PodLevelResourcesFixKubeletQOSClass (Beta, enabled by default since v1.37) to Feature Gate and Dependencies sections
  • NDF declaration decoupled from cgroupsv2: Discover() only checks the feature gate; cgroupsv1 incompatibility is handled by kubelet admission
  • Kubelet gate-off behavior: Kubelet rejects pods during admission when gate is off, not silently falls back to node default
  • Version skew: Updated all scenarios to reflect fail-closed kubelet admission
  • Validation ratcheting: Apiserver uses validation rejection + ratcheting for existing pods, not field stripping
  • Enforcement function: min() capping logic lives in EnsureExists, not getPodPIDLimit
  • Eviction e2e tests: Removed 4 eviction e2e scenarios (coverage moved to unit tests)
  • Minor cleanup: Removed misleading intro line in Valid Values section

Related PRs

/sig node
/cc @haircommander @ngopalak-redhat

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

Hi @BhargaviGudi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow
kubernetes-prow Bot requested review from dchen1107 and mrunalp July 27, 2026 11:58
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BhargaviGudi
Once this PR has been reviewed and has the lgtm label, please assign derekwaynecarr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 27, 2026
@BhargaviGudi

BhargaviGudi commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@SergeyKanzhelev @haircommander @mrunalp

This updates the KEP README to reflect the current Alpha implementation in kubernetes/kubernetes#139277:

  • Resource name is pids (plural), not pid
  • Removed kubelet_pod_pid_limit_applied_total metric (deferred past Alpha per review feedback)
  • Added PodLevelResourcesFixKubeletQOSClass as a required dependency

No functional changes; just aligning the KEP with implementation.
Could you please help to review and approve the PR? Thanks

@harche

harche commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

/assign

@harche harche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the KEP to match the implementation. One spot I could not attach an inline comment to because the line is outside the diff: the Risks item "Version skew: apiserver accepts but kubelet ignores" has the same outdated assumption as my comment on the Feature Gate section, with the fail closed admission the kubelet rejects the pod rather than silently applying the node default: https://github.com/kubernetes/kubernetes/blob/f050421a6693073df402fde0cc9f3568087c2d1e/pkg/kubelet/lifecycle/features_linux.go#L62-L70

Comment thread keps/sig-node/6063-pod-pid-limit/README.md Outdated
Comment thread keps/sig-node/6063-pod-pid-limit/README.md Outdated
Comment thread keps/sig-node/6063-pod-pid-limit/README.md Outdated
Comment thread keps/sig-node/6063-pod-pid-limit/README.md Outdated
Comment thread keps/sig-node/6063-pod-pid-limit/README.md Outdated
Comment thread keps/sig-node/6063-pod-pid-limit/README.md Outdated
Comment thread keps/sig-node/6063-pod-pid-limit/README.md Outdated
Comment thread keps/sig-node/6063-pod-pid-limit/README.md Outdated
Comment thread keps/sig-node/6063-pod-pid-limit/README.md Outdated
@harche

harche commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 27, 2026
@BhargaviGudi

Copy link
Copy Markdown
Contributor Author

/test pull-enhancements-test

@BhargaviGudi
BhargaviGudi force-pushed the kep-6063-update-readme branch 3 times, most recently from 472e73a to ce9b942 Compare July 27, 2026 17:10
- Resource name is pids (plural), not pid
- Remove kubelet_pod_pid_limit_applied_total metric (deferred past Alpha)
- Add PodLevelResourcesFixKubeletQOSClass as a required dependency
- Clean up Valid Values section
@BhargaviGudi
BhargaviGudi force-pushed the kep-6063-update-readme branch from ce9b942 to 8d8acea Compare July 27, 2026 17:37
@harche

harche commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

LGTM.

/hold until kubernetes/kubernetes#139277 merges, so that we can accommodate more amendments, should we need any more.

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants