KEP-2149, KEP-4322: Allow a cluster to belong to multiple ClusterSets - #6239
Draft
kahirokunn wants to merge 2 commits into
Draft
KEP-2149, KEP-4322: Allow a cluster to belong to multiple ClusterSets#6239kahirokunn wants to merge 2 commits into
kahirokunn wants to merge 2 commits into
Conversation
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
…perty Signed-off-by: kahirokunn <okinakahiro@gmail.com>
kubernetes-prow
Bot
added
the
kind/kep
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kahirokunn The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
sig/multicluster
Member
|
CC @lauralorenz |
mikeshng
reviewed
Jul 14, 2026
mikeshng
left a comment
mikeshng
left a comment
Member
There was a problem hiding this comment.
This update might not be needed if we do #6237 (review)
mikeshng
reviewed
Jul 15, 2026
mikeshng
left a comment
mikeshng
left a comment
Member
There was a problem hiding this comment.
Instead of multiple clusterSet, how about multiple clusterInventory instead: #6237 (review)
Contributor
Author
|
That sounds good. I've fixed 🙏 |
kahirokunn
marked this pull request as draft
July 15, 2026 08:35
kubernetes-prow
Bot
added
the
do-not-merge/work-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line PR description: Remove the single-ClusterSet-membership assumption from KEP-2149 and KEP-4322, encoding multiple memberships as a comma-separated
clusterset.k8s.iovalueIssue link: KEP-2149, KEP-4322: Allow a cluster to belong to multiple ClusterSets #6238
Other comments:
One commit per KEP:
KEP-2149: the
clusterset.k8s.ioproperty value becomes a comma-separated list of every ClusterSet the cluster belongs to; multi-membership moves from Non-Goals to Goals.KEP-4322: ClusterSet membership is expressed by the
clusterset.k8s.ioproperty; the requirement to label the inventory namespace withclusterset.multicluster.x-k8s.iois dropped; cluster managers SHOULD mirror each membership as aclusterset.multicluster.x-k8s.io/<name>: "true"label so ClusterProfiles stay selectable with standard label selectors.