[TestOnly]Add workload cluster kube-system logs to artifacts #1508
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zhanggbj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/test pull-cloud-provider-vsphere-e2e-test |
|
I think the e2e tests are broken at all :) saw similar issue on my PR @chrischdi ideas? |
|
/retest (did some fixups yesterday) Note: maybe you want to consider kubernetes-sigs/cluster-api-provider-vsphere#3490 |
|
@zhanggbj: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| By("Dump workload resources to artifacts", func() { | ||
| framework.DumpAllResources(ctx, framework.DumpAllResourcesInput{ | ||
| Lister: workloadProxy.GetClient(), | ||
| KubeConfigPath: workloadProxy.GetKubeconfigPath(), | ||
| ClusterctlConfigPath: workloadKubeconfig, | ||
| Namespace: "kube-system", | ||
| LogPath: filepath.Join(artifactFolder, "clusters", workloadProxy.GetName(), "resources"), | ||
| }) | ||
| }) |
There was a problem hiding this comment.
DumpAllResources tries to dump CAPI resources from a workload cluster (which does not have the CRD's installed or any information of them).
It also does not dump any logs afaik. (it uses the logpath to dump clusterctl describe, but that also only makes sense in a management cluster).
There was a problem hiding this comment.
Thanks @chrischdi. Wanted to reuse that for a quick debug for e2e failure yesterday. As you pointed, this won't help for workload cluster. Let me fix it and reopen this PR later.
zhanggbj
changed the title
4 participants
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: