Skip to content

Conversation

TortillaZHawaii
Copy link
Member

Because of the defer the shared resources mutex was locked even after the shared resource - health check - was provisioned. When provisioning multiple LBs, consequent ones would be waiting for the lock to be released, slowing down consequent ensure operations.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 6, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If the repository mantainers determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 6, 2025
@k8s-ci-robot k8s-ci-robot requested review from jiahuif and jpbetz June 6, 2025 11:33
@TortillaZHawaii
Copy link
Member Author

/unassign @jiahuif
/unassign @jpbetz

/assign @mmamczur

@TortillaZHawaii
Copy link
Member Author

/uncc @jiahuif @jpbetz

@k8s-ci-robot k8s-ci-robot removed request for jpbetz and jiahuif June 6, 2025 11:35
Because of the defer the shared resources mutex was locked even after the shared resource - health check - was provisioned. When provisioning multiple LBs, consequent ones would be waiting for the lock to be released, slowing down consequent ensure operations.
@TortillaZHawaii TortillaZHawaii force-pushed the lock-on-the-actual-shared-resources branch from 8d32fe8 to edee3e8 Compare June 10, 2025 12:01
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TortillaZHawaii
Once this PR has been reviewed and has the lgtm label, please ask for approval from mmamczur. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants