Fix typo in CA StaticAutoscaler test

[fabiante]

It seems that the node group id was supposed to be ng1.

The typo does strangely not cause the tests to break.

What type of PR is this?

/kind bug

Optionally add one or more of the following kinds if applicable:
/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

This might fix the tests not actually testing the right thing.
With the typo that was previously part of the test, its setup did not actually set up the state originally intended.

Does this PR introduce a user-facing change?

NONE

Special notes for your reviewer:

I do not yet know why this typo did not surface earlier. I maintain a a customized fork at https://github.com/gridscale/autoscaler where the forks modifications resulted in a panic when running the autoscaler tests.

To me it looks pretty much like a typo that was not indended, given that there is also not an explicit comment that the , was intended to be part of this string.

Edit: I opened this as a draft PR to let the tests run. Locally they passed but I want to make sure CI passes too. I will address the automation comments next.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: fabiante / name: fabiante (92d5006)

[k8s-ci-robot]

Welcome @fabiante!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @fabiante. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jackfrancis]

@fabiante could you address the CLA item and then move this PR into a ready for review (non-Draft) state?

thank you!

[fabiante]

Is there any pending thing I still need to to to so this is ready for review? To me it looks alright, LMK.

[elmiko]

@fabiante no, i think we just missed that the CLA had been signed.

assuming all the tests are good, this should be easy to merge.

/ok-to-test

[elmiko]

code change looks good, let's see if the test pass.

/lgtm

[elmiko]

seems like tests are good, thanks again for the fix @fabiante

/approve

[jackfrancis]

/lgtm
/approve
/release-note-none

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, fabiante, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS [jackfrancis]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment